public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: mediatek: Drop __initconst from gates
@ 2025-12-23 11:05 Sjoerd Simons
  2025-12-23 11:07 ` kernel test robot
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Sjoerd Simons @ 2025-12-23 11:05 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Matthias Brugger,
	AngeloGioacchino Del Regno, Laura Nao, Chen-Yu Tsai
  Cc: kernel, linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek,
	stable, Sjoerd Simons

Since commit 8ceff24a754a ("clk: mediatek: clk-gate: Refactor
mtk_clk_register_gate to use mtk_gate struct") the mtk_gate structs
are no longer just used for initialization/registration, but also at
runtime. So drop __initconst annotations.

Fixes: 8ceff24a754a ("clk: mediatek: clk-gate: Refactor mtk_clk_register_gate to use mtk_gate struct")
Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
---
 drivers/clk/mediatek/clk-mt7981-eth.c | 6 +++---
 drivers/clk/mediatek/clk-mt8516.c     | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt7981-eth.c b/drivers/clk/mediatek/clk-mt7981-eth.c
index 906aec9ddff5..0655ebb6c561 100644
--- a/drivers/clk/mediatek/clk-mt7981-eth.c
+++ b/drivers/clk/mediatek/clk-mt7981-eth.c
@@ -31,7 +31,7 @@ static const struct mtk_gate_regs sgmii0_cg_regs = {
 		.ops = &mtk_clk_gate_ops_no_setclr_inv,	\
 	}
 
-static const struct mtk_gate sgmii0_clks[] __initconst = {
+static const struct mtk_gate sgmii0_clks[] = {
 	GATE_SGMII0(CLK_SGM0_TX_EN, "sgm0_tx_en", "usb_tx250m", 2),
 	GATE_SGMII0(CLK_SGM0_RX_EN, "sgm0_rx_en", "usb_eq_rx250m", 3),
 	GATE_SGMII0(CLK_SGM0_CK0_EN, "sgm0_ck0_en", "usb_ln0", 4),
@@ -53,7 +53,7 @@ static const struct mtk_gate_regs sgmii1_cg_regs = {
 		.ops = &mtk_clk_gate_ops_no_setclr_inv,	\
 	}
 
-static const struct mtk_gate sgmii1_clks[] __initconst = {
+static const struct mtk_gate sgmii1_clks[] = {
 	GATE_SGMII1(CLK_SGM1_TX_EN, "sgm1_tx_en", "usb_tx250m", 2),
 	GATE_SGMII1(CLK_SGM1_RX_EN, "sgm1_rx_en", "usb_eq_rx250m", 3),
 	GATE_SGMII1(CLK_SGM1_CK1_EN, "sgm1_ck1_en", "usb_ln0", 4),
@@ -75,7 +75,7 @@ static const struct mtk_gate_regs eth_cg_regs = {
 		.ops = &mtk_clk_gate_ops_no_setclr_inv,	\
 	}
 
-static const struct mtk_gate eth_clks[] __initconst = {
+static const struct mtk_gate eth_clks[] = {
 	GATE_ETH(CLK_ETH_FE_EN, "eth_fe_en", "netsys_2x", 6),
 	GATE_ETH(CLK_ETH_GP2_EN, "eth_gp2_en", "sgm_325m", 7),
 	GATE_ETH(CLK_ETH_GP1_EN, "eth_gp1_en", "sgm_325m", 8),
diff --git a/drivers/clk/mediatek/clk-mt8516.c b/drivers/clk/mediatek/clk-mt8516.c
index 21eb052b0a53..342a59019fea 100644
--- a/drivers/clk/mediatek/clk-mt8516.c
+++ b/drivers/clk/mediatek/clk-mt8516.c
@@ -544,7 +544,7 @@ static const struct mtk_gate_regs top5_cg_regs = {
 #define GATE_TOP5(_id, _name, _parent, _shift)				\
 	GATE_MTK(_id, _name, _parent, &top5_cg_regs, _shift, &mtk_clk_gate_ops_setclr)
 
-static const struct mtk_gate top_clks[] __initconst = {
+static const struct mtk_gate top_clks[] = {
 	/* TOP1 */
 	GATE_TOP1(CLK_TOP_THEM, "them", "ahb_infra_sel", 1),
 	GATE_TOP1(CLK_TOP_APDMA, "apdma", "ahb_infra_sel", 2),

---
base-commit: b927546677c876e26eba308550207c2ddf812a43
change-id: 20251223-mtk-gate-a98133ab80c9

Best regards,
-- 
Sjoerd Simons <sjoerd@collabora.com>


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: mediatek: Drop __initconst from gates
  2025-12-23 11:05 [PATCH] clk: mediatek: Drop __initconst from gates Sjoerd Simons
@ 2025-12-23 11:07 ` kernel test robot
  2026-01-07 11:12 ` AngeloGioacchino Del Regno
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2025-12-23 11:07 UTC (permalink / raw)
  To: Sjoerd Simons; +Cc: stable, oe-kbuild-all

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: stable@vger.kernel.org" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH] clk: mediatek: Drop __initconst from gates
Link: https://lore.kernel.org/stable/20251223-mtk-gate-v1-1-e4a489ab33de%40collabora.com

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: mediatek: Drop __initconst from gates
  2025-12-23 11:05 [PATCH] clk: mediatek: Drop __initconst from gates Sjoerd Simons
  2025-12-23 11:07 ` kernel test robot
@ 2026-01-07 11:12 ` AngeloGioacchino Del Regno
  2026-01-13 16:14 ` Laura Nao
  2026-01-23  1:43 ` Stephen Boyd
  3 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-01-07 11:12 UTC (permalink / raw)
  To: Sjoerd Simons, Michael Turquette, Stephen Boyd, Matthias Brugger,
	Laura Nao, Chen-Yu Tsai
  Cc: kernel, linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek,
	stable

Il 23/12/25 12:05, Sjoerd Simons ha scritto:
> Since commit 8ceff24a754a ("clk: mediatek: clk-gate: Refactor
> mtk_clk_register_gate to use mtk_gate struct") the mtk_gate structs
> are no longer just used for initialization/registration, but also at
> runtime. So drop __initconst annotations.
> 
> Fixes: 8ceff24a754a ("clk: mediatek: clk-gate: Refactor mtk_clk_register_gate to use mtk_gate struct")
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: mediatek: Drop __initconst from gates
  2025-12-23 11:05 [PATCH] clk: mediatek: Drop __initconst from gates Sjoerd Simons
  2025-12-23 11:07 ` kernel test robot
  2026-01-07 11:12 ` AngeloGioacchino Del Regno
@ 2026-01-13 16:14 ` Laura Nao
  2026-01-23  1:43 ` Stephen Boyd
  3 siblings, 0 replies; 5+ messages in thread
From: Laura Nao @ 2026-01-13 16:14 UTC (permalink / raw)
  To: sjoerd
  Cc: angelogioacchino.delregno, kernel, laura.nao, linux-arm-kernel,
	linux-clk, linux-kernel, linux-mediatek, matthias.bgg, mturquette,
	sboyd, stable, wenst

On 12/23/25 12:05, Sjoerd Simons wrote:
> Since commit 8ceff24a754a ("clk: mediatek: clk-gate: Refactor
> mtk_clk_register_gate to use mtk_gate struct") the mtk_gate structs
> are no longer just used for initialization/registration, but also at
> runtime. So drop __initconst annotations.
>
> Fixes: 8ceff24a754a ("clk: mediatek: clk-gate: Refactor mtk_clk_register_gate to use mtk_gate struct")
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>

Reviewed-by: Laura Nao <laura.nao@collabora.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clk: mediatek: Drop __initconst from gates
  2025-12-23 11:05 [PATCH] clk: mediatek: Drop __initconst from gates Sjoerd Simons
                   ` (2 preceding siblings ...)
  2026-01-13 16:14 ` Laura Nao
@ 2026-01-23  1:43 ` Stephen Boyd
  3 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2026-01-23  1:43 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno, Chen-Yu Tsai, Laura Nao,
	Matthias Brugger, Michael Turquette, Sjoerd Simons
  Cc: kernel, linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek,
	stable, Sjoerd Simons

Quoting Sjoerd Simons (2025-12-23 04:05:17)
> Since commit 8ceff24a754a ("clk: mediatek: clk-gate: Refactor
> mtk_clk_register_gate to use mtk_gate struct") the mtk_gate structs
> are no longer just used for initialization/registration, but also at
> runtime. So drop __initconst annotations.
> 
> Fixes: 8ceff24a754a ("clk: mediatek: clk-gate: Refactor mtk_clk_register_gate to use mtk_gate struct")
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-01-23  1:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-23 11:05 [PATCH] clk: mediatek: Drop __initconst from gates Sjoerd Simons
2025-12-23 11:07 ` kernel test robot
2026-01-07 11:12 ` AngeloGioacchino Del Regno
2026-01-13 16:14 ` Laura Nao
2026-01-23  1:43 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox