From: "tip-bot2 for Jassi Brar" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Thomas Gleixner <tglx@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
stable@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/urgent] irqchip/qcom-mpm: Add missing mailbox TX done acknowledgment
Date: Tue, 24 Mar 2026 16:09:49 -0000 [thread overview]
Message-ID: <177436858927.1647592.6531954753628943644.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260322171533.608436-1-jassisinghbrar@gmail.com>
The following commit has been merged into the irq/urgent branch of tip:
Commit-ID: 213a1f66341adf9e911b5c887970f209c132c4c0
Gitweb: https://git.kernel.org/tip/213a1f66341adf9e911b5c887970f209c132c4c0
Author: Jassi Brar <jassisinghbrar@gmail.com>
AuthorDate: Sun, 22 Mar 2026 12:15:33 -05:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Tue, 24 Mar 2026 17:03:26 +01:00
irqchip/qcom-mpm: Add missing mailbox TX done acknowledgment
The mbox_client for qcom-mpm sends NULL doorbell messages via
mbox_send_message() but never signals TX completion.
Set knows_txdone=true and call mbox_client_txdone() after a successful
send, matching the pattern used by other Qualcomm mailbox clients (smp2p,
smsm, qcom_aoss etc).
Fixes: a6199bb514d8a6 "irqchip: Add Qualcomm MPM controller driver"
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20260322171533.608436-1-jassisinghbrar@gmail.com
---
drivers/irqchip/irq-qcom-mpm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c
index 83f31ea..1813205 100644
--- a/drivers/irqchip/irq-qcom-mpm.c
+++ b/drivers/irqchip/irq-qcom-mpm.c
@@ -306,6 +306,8 @@ static int mpm_pd_power_off(struct generic_pm_domain *genpd)
if (ret < 0)
return ret;
+ mbox_client_txdone(priv->mbox_chan, 0);
+
return 0;
}
@@ -434,6 +436,7 @@ static int qcom_mpm_probe(struct platform_device *pdev, struct device_node *pare
}
priv->mbox_client.dev = dev;
+ priv->mbox_client.knows_txdone = true;
priv->mbox_chan = mbox_request_channel(&priv->mbox_client, 0);
if (IS_ERR(priv->mbox_chan)) {
ret = PTR_ERR(priv->mbox_chan);
prev parent reply other threads:[~2026-03-24 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 17:15 [PATCHv2] irqchip/qcom-mpm: Fix missing mailbox TX done acknowledgment jassisinghbrar
2026-03-24 16:09 ` tip-bot2 for Jassi Brar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177436858927.1647592.6531954753628943644.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=dianders@chromium.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox