Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Amaan Cheval <amaan.cheval@gmail.com>
Cc: netdev@vger.kernel.org, joshwash@google.com,
	hramamurthy@google.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, bcf@google.com, jordanrhee@google.com,
	przemyslaw.kitszel@intel.com, maciej.fijalkowski@intel.com,
	pkaligineedi@google.com, maolson@google.com, csully@google.com,
	willemb@google.com, yangchun@google.com, npl@google.com,
	awogbemila@google.com, shailend@google.com, nktgrg@google.com,
	maxyuan@google.com, bpf@vger.kernel.org,
	john.fastabend@gmail.com, hawk@kernel.org, sdf@fomichev.me,
	daniel@iogearbox.net, ast@kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v6 0/2] gve: fix RX page refcount overflow with the pagecnt bias
Date: Tue, 17 Nov 2026 00:10:06 +0000	[thread overview]
Message-ID: <179487420603.254275.3233065832052946037.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261112091451.22969-1-amaan.cheval@gmail.com>

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 12 Nov 2026 14:44:49 +0530 you wrote:
> gve's GQI and DQO-QPL RX paths bias every RX page's refcount to INT_MAX,
> so a single get_page() from the stack, e.g. splice() of received data,
> overflows it: splice/tee fail with EIO/EFAULT and GQI can reset the
> NIC. Patch 2 lowers the bias to USHRT_MAX, as other drivers do.
> 
> With the smaller bias the driver gives up its last reference on a page
> once every USHRT_MAX handoffs instead of once every INT_MAX, which is
> only safe while every consumer holds its reference until the buffer is
> recycled. That is not the case for an XDP_REDIRECT from DQO-QPL to an
> AF_XDP socket in copy mode, a path the driver never meant to support:
> commit d8a8ca14c937 dropped the queue_format check that used to refuse
> it. Patch 1 refuses XDP on any queue format the driver advertises no
> XDP features for, today DQO-QPL and GQI-RDA, so patch 2 depends on it.
> On GQI-RDA it also stops XDP_TX from writing into a TX FIFO that raw
> addressing never allocates. Trees before 6.17 still have the old check,
> so there patch 2 stands alone.
> 
> [...]

Here is the summary with links:
  - [net,v6,1/2] gve: refuse XDP on queue formats without XDP support
    https://git.kernel.org/netdev/net/c/92c569c28b63
  - [net,v6,2/2] gve: fix RX page refcount overflow from INT_MAX pagecnt_bias
    https://git.kernel.org/netdev/net/c/3946899dbeac

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-11-17  0:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  9:14 [PATCH net v6 0/2] gve: fix RX page refcount overflow with the pagecnt bias Amaan Cheval
2026-11-12  9:14 ` [PATCH net v6 1/2] gve: refuse XDP on queue formats without XDP support Amaan Cheval
2026-11-12  9:14 ` [PATCH net v6 2/2] gve: fix RX page refcount overflow from INT_MAX pagecnt_bias Amaan Cheval
2026-11-12  9:22 ` [PATCH net v6 0/2] gve: fix RX page refcount overflow with the pagecnt bias netdev-bot+sinfo
2026-11-12 14:19   ` Amaan Cheval
2026-11-17  0:10 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179487420603.254275.3233065832052946037.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=amaan.cheval@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=awogbemila@google.com \
    --cc=bcf@google.com \
    --cc=bpf@vger.kernel.org \
    --cc=csully@google.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hawk@kernel.org \
    --cc=hramamurthy@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jordanrhee@google.com \
    --cc=joshwash@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=maolson@google.com \
    --cc=maxyuan@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nktgrg@google.com \
    --cc=npl@google.com \
    --cc=pabeni@redhat.com \
    --cc=pkaligineedi@google.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=sdf@fomichev.me \
    --cc=shailend@google.com \
    --cc=stable@vger.kernel.org \
    --cc=willemb@google.com \
    --cc=yangchun@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox