Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: chenyichong@uniontech.com
Cc: alex.aring@gmail.com, stefan@datenfreihafen.org,
	miquel.raynal@bootlin.com, linux-wpan@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	zhanjun@uniontech.com,
	syzbot+8a8482d4c33cc58babb4@syzkaller.appspotmail.com,
	stable@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net] ieee802154: hwsim: free PIB after hardware unregister
Date: Tue, 17 Nov 2026 13:55:37 +0000	[thread overview]
Message-ID: <179492373789.3136.2399679338709401263@kernel.org> (raw)
In-Reply-To: <0D7C088B45E7283A+20261113134141.2626113-1-chenyichong@uniontech.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 1 · Medium: 0 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [High] The patch fixes the stale-PIB double free in hwsim_del(), but
  the error unwind in hwsim_add_one()…

--

ieee802154: hwsim: free PIB after hardware unregister

This patch reorders hwsim_del() so that ieee802154_unregister_hw() runs
before the PIB is freed. The current phy->pib is then detached under
pib_lock with rcu_replace_pointer(), and only that object is passed to
kfree_rcu(). This avoids a double free when a scan abort replaces the PIB
during teardown.

Closes: https://lore.kernel.org/all/6af5f575.b350cda4.2b6a63.0000.GAE@google.com/T/

> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
> index a9bd1555d2dc7..a65ae2afb789b 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -1008,12 +1008,16 @@ static void hwsim_del(struct hwsim_phy *phy)
>  		list_del_rcu(&e->list);
>  		hwsim_free_edge(e);
>  	}
> -	pib = rcu_dereference(phy->pib);
>  	rcu_read_unlock();
>  
> +	ieee802154_unregister_hw(phy->hw);
> +
> +	spin_lock_bh(&phy->pib_lock);
> +	pib = rcu_replace_pointer(phy->pib, NULL,
> +				  lockdep_is_held(&phy->pib_lock));
> +	spin_unlock_bh(&phy->pib_lock);
>  	kfree_rcu(pib, rcu);

[Severity: High]
This fixes hwsim_del(). Does the error unwind in hwsim_add_one() still
have the same stale PIB problem?

hwsim_add_one() keeps the original PIB in a local variable and frees that
pointer directly on failure:

drivers/net/ieee802154/mac802154_hwsim.c:hwsim_add_one() {
    ...
	rcu_assign_pointer(phy->pib, pib);
    ...
	err = ieee802154_register_hw(hw);
	if (err)
		goto err_reg;
    ...
err_subscribe:
	ieee802154_unregister_hw(phy->hw);
err_reg:
	kfree(pib);
err_pib:
	ieee802154_free_hw(phy->hw);
}

After wpan_phy_register() runs inside ieee802154_register_hw(), driver
callbacks can replace phy->pib through hwsim_update_pib(). That function
calls kfree_rcu(pib_old) on the original object. Some of the paths that
get there:

  NL802154_CMD_SET_CHANNEL -> ieee802154_set_channel() -> drv_set_channel()
    -> hwsim_hw_channel() -> hwsim_update_pib()

  interface open -> drv_start() -> set_promiscuous_mode / set_hw_addr_filt

  scan abort inside ieee802154_unregister_hw(), which is the path the
  commit message describes

On the err_subscribe path, ieee802154_unregister_hw() runs first and then
falls through to kfree(pib). This happens when hwsim_probe() calls with
init set and hwsim_subscribe_all_others() fails with -ENOMEM.

The HWSIM_CMD_NEW_RADIO path can also reach err_reg, when
ieee802154_if_add() fails after wpan_phy_register() has succeeded.
wpan_phy_register() drops rtnl before ieee802154_register_hw() takes it
again. A SET_CHANNEL request can run in that window and replace the PIB:

net/mac802154/main.c:ieee802154_register_hw() {
    ...
	rc = wpan_phy_register(local->phy);
	if (rc < 0)
		goto out_mac_wq;

	rtnl_lock();

	dev = ieee802154_if_add(local, "wpan%d", NET_NAME_ENUM,
				NL802154_IFTYPE_NODE,
				cpu_to_le64(0x0000000000000000ULL));
	if (IS_ERR(dev)) {
		rtnl_unlock();
		rc = PTR_ERR(dev);
		goto out_phy;
	}
    ...
}

In both cases, wouldn't kfree(pib) free an object that is already queued
for kfree_rcu()? Wouldn't it also leak the PIB that is currently
installed in phy->pib?

The commit message says the change "avoids freeing a PIB that was already
replaced during teardown". Should the hwsim_add_one() unwind follow the
same sequence that hwsim_del() now uses? That would mean detaching
phy->pib under pib_lock with rcu_replace_pointer() after unregistering
the hardware, and passing the result to kfree_rcu(), rather than calling
kfree() on the saved local pointer.

>  
> -	ieee802154_unregister_hw(phy->hw);
>  	ieee802154_free_hw(phy->hw);
>  }

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/0D7C088B45E7283A%2B20261113134141.2626113-1-chenyichong%40uniontech.com

      parent reply	other threads:[~2026-11-17 13:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 13:41 [PATCH net] ieee802154: hwsim: free PIB after hardware unregister Yichong Chen
2026-11-17 10:17 ` Miquel Raynal
2026-11-17 13:55 ` netdev-bot+sashiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179492373789.3136.2399679338709401263@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=alex.aring@gmail.com \
    --cc=chenyichong@uniontech.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    --cc=syzbot+8a8482d4c33cc58babb4@syzkaller.appspotmail.com \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox