RE: [PATCH] serial: sc16is7xx: fix bug in sc16is7xx_set_baud() when using prescaler

David Laight
2024-04-29T09:14:52Z

From: Jiri Slaby
> Sent: 29 April 2024 07:39
...
> > - u8 prescaler = 0;
> > + int prescaler = 1;
>
> Ugh, why do you move to signed arithmetics?

Any arithmetic would always have been signed.
u8 is promoted to 'signed int' before being used for pretty much anything.

'unsigned int prescaler' might have changed arithmetic to be unsigned.

OTOH you probably don't want a u8 - that might require the compiler
mask an arithmetic result to 8 bits.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)