From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:39510 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbdJRVnd (ORCPT ); Wed, 18 Oct 2017 17:43:33 -0400 From: David Howells In-Reply-To: <20171018205626.25391-1-mjg59@google.com> References: <20171018205626.25391-1-mjg59@google.com> To: Matthew Garrett Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, Alexander Viro , stable@vger.kernel.org Subject: Re: [PATCH V2] Fix mounting with MS_I_VERSION MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <18014.1508363011.1@warthog.procyon.org.uk> Date: Wed, 18 Oct 2017 22:43:31 +0100 Message-ID: <18015.1508363011@warthog.procyon.org.uk> Sender: stable-owner@vger.kernel.org List-ID: Matthew Garrett wrote: > commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > internal superblock flags") reworked the flags that are passed through > do mount, and in the process dropped MS_I_VERSION. Confusingly, things > continue working if the i_version mount option is used because that's > directly passed to ext4 which interprets it, while iversion is turned > into MS_I_VERSION and dropped on the floor. This breaks IMA and EVM and > my heart. Pass SB_I_VERSION through, and update the consumers to use it > instead of MS_I_VERSION. > > Signed-off-by: Matthew Garrett > Cc: David Howells > Cc: Alexander Viro > Cc: stable@vger.kernel.org Reviewed-by: David Howells