From: Sven Eckelmann <sven@narfation.org>
To: Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>,
Antonio Quartulli <a@unstable.cc>,
Remi Pommarel <repk@triplefau.lt>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Remi Pommarel <repk@triplefau.lt>,
stable@vger.kernel.org
Subject: Re: [PATCH net] batman-adv: Fix batadv_v_ogm_aggr_send memory leak
Date: Wed, 09 Aug 2023 17:33:49 +0200 [thread overview]
Message-ID: <1951515.yKVeVyVuyW@ripper> (raw)
In-Reply-To: <20230809152913.27218-1-repk@triplefau.lt>
[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]
On Wed, 09 Aug 2023 17:29:13 +0200, Remi Pommarel wrote:
> When batadv_v_ogm_aggr_send is called for an inactive interface, the skb
> is silently dropped by batadv_v_ogm_send_to_if() but never freed causing
> the following memory leak:
>
> unreferenced object 0xffff00000c164800 (size 512):
> comm "kworker/u8:1", pid 2648, jiffies 4295122303 (age 97.656s)
> hex dump (first 32 bytes):
> 00 80 af 09 00 00 ff ff e1 09 00 00 75 01 60 83 ............u.`.
> 1f 00 00 00 b8 00 00 00 15 00 05 00 da e3 d3 64 ...............d
> backtrace:
> [<0000000007ad20f6>] __kmalloc_track_caller+0x1a8/0x310
> [<00000000d1029e55>] kmalloc_reserve.constprop.0+0x70/0x13c
> [<000000008b9d4183>] __alloc_skb+0xec/0x1fc
> [<00000000c7af5051>] __netdev_alloc_skb+0x48/0x23c
> [<00000000642ee5f5>] batadv_v_ogm_aggr_send+0x50/0x36c
> [<0000000088660bd7>] batadv_v_ogm_aggr_work+0x24/0x40
> [<0000000042fc2606>] process_one_work+0x3b0/0x610
> [<000000002f2a0b1c>] worker_thread+0xa0/0x690
> [<0000000059fae5d4>] kthread+0x1fc/0x210
> [<000000000c587d3a>] ret_from_fork+0x10/0x20
>
> [...]
Applied, thanks!
[1/1] batman-adv: Fix batadv_v_ogm_aggr_send memory leak
commit: 421d467dc2d483175bad4fb76a31b9e5a3d744cf
Best regards,
--
Sven Eckelmann <sven@narfation.org>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-08-09 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 15:29 [PATCH net] batman-adv: Fix batadv_v_ogm_aggr_send memory leak Remi Pommarel
2023-08-09 15:33 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1951515.yKVeVyVuyW@ripper \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=repk@triplefau.lt \
--cc=stable@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox