Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: RigoLigo <rigoligo03@gmail.com>
To: Ilikara Zheng <ilikara@aosc.io>, linux-kernel@vger.kernel.org
Cc: Mingcong Bai <jeffbai@aosc.io>,
	Kexy Biscuit <kexybiscuit@aosc.io>,
	stable@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds
Date: Mon, 8 Dec 2025 21:27:56 +0800	[thread overview]
Message-ID: <19627811-c325-4ef3-8982-59fcd9ecbdfb@gmail.com> (raw)
In-Reply-To: <20251208132340.1317531-1-ilikara@aosc.io>

Hi all,

On 2025-12-08 21:23, Ilikara Zheng wrote:
> Secondary temperature thresholds (temp2_{min,max}) were not reported
> properly on this NVMe SSD. This resulted in an error while attempting to
> read these values with sensors(1):
> 
>    ERROR: Can't get value of subfeature temp2_min: I/O error
>    ERROR: Can't get value of subfeature temp2_max: I/O error
> 
> Add the device to the nvme_id_table with the
> NVME_QUIRK_NO_SECONDARY_TEMP_THRESH flag to suppress access to all non-
> composite temperature thresholds.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Ilikara Zheng <ilikara@aosc.io>
> ---
>   drivers/nvme/host/pci.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index e5ca8301bb8b..31049f33f27d 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3997,6 +3997,8 @@ static const struct pci_device_id nvme_id_table[] = {
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
>   	{ PCI_DEVICE(0x1e49, 0x0041),   /* ZHITAI TiPro7000 NVMe SSD */
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
> +	{ PCI_DEVICE(0x1fa0, 0x2283),   /* Wodposit WPBSNM8-256GTP */
> +		.driver_data = NVME_QUIRK_NO_SECONDARY_TEMP_THRESH, },
>   	{ PCI_DEVICE(0x025e, 0xf1ac),   /* SOLIDIGM  P44 pro SSDPFKKW020X7  */
>   		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
>   	{ PCI_DEVICE(0xc0a9, 0x540a),   /* Crucial P2 */

I have tested this patch on a CTCISZ 3B6000M-NUC with an exact same SSD 
and this has resolved the error with sensor(1).

Tested-by: Wu Haotian <rigoligo03@gmail.com>

  reply	other threads:[~2025-12-08 13:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08 13:23 [PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds Ilikara Zheng
2025-12-08 13:27 ` RigoLigo [this message]
2025-12-15 13:52 ` Ilikara Zheng
2025-12-15 15:32 ` Keith Busch
2025-12-16 13:47   ` Ilikara Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19627811-c325-4ef3-8982-59fcd9ecbdfb@gmail.com \
    --to=rigoligo03@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=ilikara@aosc.io \
    --cc=jeffbai@aosc.io \
    --cc=kbusch@kernel.org \
    --cc=kexybiscuit@aosc.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox