Re: [PATCH 1/2] mmc: sdhci-uhs2: Fix calling incorrect sdhci_set_clock() function

[Adrian Hunter <adrian.hunter@intel.com>]

On 01/09/2025 15:07, Adrian Hunter wrote:
> On 01/09/2025 12:40, Ben Chuang wrote:
>> From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
>>
>> Fix calling incorrect sdhci_set_clock() in __sdhci_uhs2_set_ios() when the
>> vendor defines its own sdhci_set_clock().
>>
>> Fixes: 10c8298a052b ("mmc: sdhci-uhs2: add set_ios()")
>> Cc: stable@vger.kernel.org # v6.13+
>> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
>> ---
>>  drivers/mmc/host/sdhci-uhs2.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc/host/sdhci-uhs2.c
>> index 0efeb9d0c376..704fdc946ac3 100644
>> --- a/drivers/mmc/host/sdhci-uhs2.c
>> +++ b/drivers/mmc/host/sdhci-uhs2.c
>> @@ -295,7 +295,10 @@ static void __sdhci_uhs2_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>>  	else
>>  		sdhci_uhs2_set_power(host, ios->power_mode, ios->vdd);
>>  
>> -	sdhci_set_clock(host, host->clock);
>> +	if (host->ops->set_clock)
>> +		host->ops->set_clock(host, host->clock);
>> +	else
>> +		sdhci_set_clock(host, host->clock);
> 
> host->ops->set_clock is not optional.  So this should just be:
> 
> 	host->ops->set_clock(host, host->clock);
> 

Although it seems we are setting the clock in 2 places:

	sdhci_uhs2_set_ios()
		sdhci_set_ios_common()
			host->ops->set_clock(host, ios->clock)
	      __sdhci_uhs2_set_ios
			sdhci_set_clock(host, host->clock)
			
Do we really need both?