From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 930BA22D9E9 for ; Tue, 9 Sep 2025 08:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757406850; cv=none; b=FNWffFboR4tCjXIJgFhUX+Upx8PKZWebESOfTDQ/59xalz+oCl1U+ocyUrLjRsfMtlkcaPLn7ricK+pNPh4rvgvzLnE7glPXB7czWNTV3ZRQWuPXryoRNMyJ5jt0C68hyLhOqJOBaygQ6wVnfiiwqqT6LbTvV3lwWKdzeMzr3ig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757406850; c=relaxed/simple; bh=upmujvJfvnWBaiiN0ti0rvQTX7eUdmtsYcwo6llGIhA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YoqqojRzQYeKvL/OSVnh8dvoQd77Q7oVdnzNYGM2IFoovcK9n76apgTOdGKIrEC5a4gc9utADZbUtIRp90U0X7LXo/TgaDIi8OuvKCInxcIqpB7wkCbEUSaJeTs+0bFCBbqekV7EJk8WEO9UXPq5LYhQlXZhpKYr+tL4VZ4Uj3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kEGqlLdD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kEGqlLdD" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5896SXuI012323 for ; Tue, 9 Sep 2025 08:34:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= upmujvJfvnWBaiiN0ti0rvQTX7eUdmtsYcwo6llGIhA=; b=kEGqlLdDFAhiru0H ACVzBaGIQxIbrhuhxQvqDUjDKI7LXobCRsLJlvv/eU+ZwKXY7CVCs+gBdB6uDHkj qXhF7Lu5bPbwYtrxSZDhqYCDZLiexhxip3pHpbVAZsGVkGFkGdNgrcMAz4+sdMXd +/ldYAvtd6esKQu6D/i2/hu7utMp3vnXbC7ngi6PNOqRUXk2fKGIwFXGKanDXLmi 5j5zsi/XpvIpW5gDA1dXqOvoJmshNVGDwhxJCWa2N7NyomvkRxgkij304lz+Xa0y +tduKnMc6pjiRm9Bg7IDvKcdv2QfTFfQRIq6W2JBWPDqVj7P596v5RA68m/ucCbX Ax7WzQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490e8a7e7p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 09 Sep 2025 08:34:08 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-32bc286bc1eso7366278a91.0 for ; Tue, 09 Sep 2025 01:34:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757406848; x=1758011648; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=upmujvJfvnWBaiiN0ti0rvQTX7eUdmtsYcwo6llGIhA=; b=O7NJLjKYdyRFtqCGMgjVNb4fjVvseiA63AP7C65gKSvzBMG0Ll1+1WW2B21NKz/DNF S28KwtwzMYNWUjkOnsuafACDwOysPAKuvFUgecV5bVGTBrZqxFa9ZgeOzgwwhBhoyeup 0M740DCimdWyZkGrJkXgAgzzNS/8139oOTN8b4NamkuZWmsdU0VC1DjnZZjGN+ueF3fv uUmEQOP8h0HmH7K8te6Xc01F4GI8fMpCnJ2oE3N6VJxTa2inV7ZOjgs/r+xxePoM2VsS wyvcvxsv1KhxN7aXaH2tJonn5uvC9SJZ+y9J8oGJd519WZYp9boekv/sD6K5uQkJeHv6 idgg== X-Forwarded-Encrypted: i=1; AJvYcCUp9mba34yMwubOxke5CKyCDARtM3Xsoj1sF5abXXvaT1BaNxzV2kRKhz+biEv63TgjA1vU2Go=@vger.kernel.org X-Gm-Message-State: AOJu0YwRhRRi+e4RgCblBGel9kq09SBBYNExpX8LxTSuInDsez3Of+rQ fSa4IWPQZTLf2OtJP9fzXYWIORXlDWKLAcVoNI4le+EIPfxVozL8RmTm4GlzG1wd5t3pBLuAwnb ArQL5phEtn+g8LGSRUYKASqDgyoQpnyfQ+ROujOZZTuOwwHuO2MLEVmRvBkw= X-Gm-Gg: ASbGncujFjlvQOTU5xad9TvWgGtq7+jR8opdicaCARl9xMidJJpKH284CcItwU/u0t9 dKbT9wDKJx3L+YdYBB8WRgxfIYfcIRA3Fh8b6yrgjDG7LfjBtEBF32WCoFfmXXCLm89pgzMeQ6x eYHjjnWNNuVvDGVt0xXsLwRW7lVp1cfZfaBV5et/PnWNBLtHitTAwon7HPuvnGsDc4lz3xEMliF ISxiGA24H4nwnVcwnIgOSFOxyOYA4Jqr8BSTfVue9soC1ovo0iYzmYiq4IgTEWQ0Pf+I4S7XjKA NQG/+34BTsLxajrTIJllf6yin6e6AGa3zA9hZKfbk00IERPPwo6osjIZjoDEaCOqRj2RiZ/WFw2 ihtw6AQZP X-Received: by 2002:a17:90b:2f4d:b0:32b:7d2f:2ee5 with SMTP id 98e67ed59e1d1-32d43f53f7fmr15226195a91.16.1757406847991; Tue, 09 Sep 2025 01:34:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFFVYaSNpwmTtzVm52pLe74SQM+AQgVs52r6EibYNw4s3M1qPfrL9xKm/fTur78uRMs2Z/xFA== X-Received: by 2002:a17:90b:2f4d:b0:32b:7d2f:2ee5 with SMTP id 98e67ed59e1d1-32d43f53f7fmr15226163a91.16.1757406847633; Tue, 09 Sep 2025 01:34:07 -0700 (PDT) Received: from [10.151.37.217] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b4fb15f50d6sm14836433a12.0.2025.09.09.01.34.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Sep 2025 01:34:07 -0700 (PDT) Message-ID: <1bed21ff-ca0d-4436-9d40-acf26dfda362@oss.qualcomm.com> Date: Tue, 9 Sep 2025 14:04:02 +0530 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] phy: qcom-qmp-usb: fix NULL pointer dereference in PM callbacks To: Vinod Koul Cc: Kishon Vijay Abraham I , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Poovendhan Selvaraj , stable@vger.kernel.org References: <20250825-qmp-null-deref-on-pm-v1-0-bbd3ca330849@oss.qualcomm.com> <20250825-qmp-null-deref-on-pm-v1-1-bbd3ca330849@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=H7Dbw/Yi c=1 sm=1 tr=0 ts=68bfe680 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=COk6AnOGAAAA:8 a=zK7o3jtn9Y8dKal1iDgA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: RKhuAOxXrwrvth5w8pnX0FVQQyEANAkk X-Proofpoint-ORIG-GUID: RKhuAOxXrwrvth5w8pnX0FVQQyEANAkk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAzOSBTYWx0ZWRfX+7tZHyz8GmTr 08Yjvtd7yl+B2TpbclF2kmdMMiY07kIAHJ9GfPRemvDSXkklhErWJe6kaoXgdQnS0NdugcWiGwV KdCTBdEV2MWqoDA5v6iAWUo3X40ess3QlQkLGkZNpxeqzcpKnbgAjNSqmTuNHYcyt29zEZHPB5p /MlBFPZwLVzI+MCJXUzHt07yE6G0eahgbqZplY6hepiYK+AynmgHtvDNOC/tJ6k8lOIxcIrgs1p 9hdqpVMl/KtxboZBdldp60vTN2Xg8htnUIEMLWF8imAueYGRmAHEjlSZSs7tcibt1ZOa/28GF6c UsueF8atBS2xVWFadVF5JX/TtVTMpet3TmKVxq0h82ivTX4xSDSE90E7IOxRXhioqXXQea5H+iU p/08wVhi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-08_06,2025-09-08_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060039 On 9/1/2025 7:24 PM, Vinod Koul wrote: > On 25-08-25, 17:22, Kathiravan Thirumoorthy wrote: >> From: Poovendhan Selvaraj >> >> The pm ops are enabled before qmp phy create which causes >> a NULL pointer dereference when accessing qmp->phy->init_count >> in the qmp_usb_runtime_suspend. >> >> So if qmp->phy is NULL, bail out early in suspend / resume callbacks >> to avoid the NULL pointer dereference in qmp_usb_runtime_suspend and >> qmp_usb_runtime_resume. > That is a band-aid. we should enable pm only when ready... > Why not do that instead? Thanks Vinod. Sorry for the delay, I'm just back from my vacation. Sure, let me check why the PM is getting enabled before its ready. Thanks, Kathiravan T.