From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Mastan Katragadda <Mastan.Katragadda@amd.com>,
"Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
"Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@amd.com>,
"kondaveeti, Arungopal" <arungopal.kondaveeti@amd.com>
Subject: Re: [PATCH] soundwire: fix initializing sysfs for same devices on different buses
Date: Thu, 5 Oct 2023 19:07:46 +0530 [thread overview]
Message-ID: <1c8e4e94-8781-7126-2ded-e4198db4129e@amd.com> (raw)
In-Reply-To: <c0cf1873-f72d-3cd3-0b70-db70d76546f5@amd.com>
On 05/10/23 18:08, Mukunda,Vijendar wrote:
> On 05/10/23 17:54, Pierre-Louis Bossart wrote:
>>
>>> I think we keep circling on the differences between "Controller" and
>>> "link" (aka bus). A Controller can have one or more links. A system can
>>> have one or more controllers.
>>>
>>> Intel platforms have one controller and 4 or more links.
>>> QCOM platforms have one or more controllers with one link each.
>>>
>>> I am not sure how this IDA-generated bus_id helps deal with these two
>>> cases, since we can't really make any assumptions on how
>>> controllers/links will be started and probed.
>>>
>>> What we are missing is a hierarchical controller/link definition, IOW a
>>> controller_id should be given to the master by a higher level instead of
>>> using an IDA.
>> Tentative patches to introduce a 'controller_id' that's not an IDA are
>> here: https://github.com/thesofproject/linux/pull/4616
>>
>> Initial results are positive for Intel devices. it *should* work for
>> other devices but I can't test. If folks at Linaro/Qualcomm and AMD can
>> give it a try, that would be much appreciated.
> Will test on AMD platforms and let you know the result.
"soundwire: bus: introduce controller_id " patch needs to be modified
and controller id should be set to zero for amd platforms as we are
populating multiple links under same controller id.
>
>> Thanks.
prev parent reply other threads:[~2023-10-05 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 13:02 [PATCH] soundwire: fix initializing sysfs for same devices on different buses Krzysztof Kozlowski
2023-10-04 13:11 ` Greg Kroah-Hartman
2023-10-04 13:15 ` Krzysztof Kozlowski
2023-10-04 13:16 ` Pierre-Louis Bossart
2023-10-04 13:38 ` Greg Kroah-Hartman
2023-10-04 13:57 ` Pierre-Louis Bossart
2023-10-04 14:13 ` Greg Kroah-Hartman
2023-10-04 15:16 ` Pierre-Louis Bossart
2023-10-04 15:40 ` Mark Brown
2023-10-04 19:00 ` Pierre-Louis Bossart
2023-10-04 19:08 ` Mark Brown
2023-10-05 12:24 ` Pierre-Louis Bossart
2023-10-05 12:38 ` Mukunda,Vijendar
2023-10-05 13:37 ` Mukunda,Vijendar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c8e4e94-8781-7126-2ded-e4198db4129e@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mastan.Katragadda@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arungopal.kondaveeti@amd.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=pombredanne@nexb.com \
--cc=sanyog.r.kale@intel.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox