From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:45719 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758934AbcHYO5m (ORCPT ); Thu, 25 Aug 2016 10:57:42 -0400 Subject: Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open To: Jiri Kosina References: <20160818135932.219369981@linuxfoundation.org> <20160818135938.484441980@linuxfoundation.org> <0df64efc-85fe-1de7-f15f-233f1e5fdad8@compro.net> <20160824201701.GB2133@kroah.com> <6b0f11af-84a4-ef0c-0033-7a10de189813@compro.net> CC: , Greg Kroah-Hartman , , , Wim Osterholt From: Jens Axboe Message-ID: <1d640422-6647-0889-7ac3-501bede1a756@fb.com> Date: Thu, 25 Aug 2016 08:57:13 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 08/25/2016 08:53 AM, Jiri Kosina wrote: > On Thu, 25 Aug 2016, Jens Axboe wrote: > >> Which patch is this? If that is truly the case, it should be reverted >> asap. > > I've been looking into this for the past few days, and unfortunately I am > not able to come up with a simple fix, so revert seems like the way to go. > > Unfortunately, by reverting the patch, we'll get back into the original > situation, where the bug found by syzkaller would be present. > > If going down the revert path, we'd have to bring the driver to the state > it was before, i.e. reverting it and the followup fix, i.e. > > ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e > 09954bad448791ef01202351d437abdd9497a804 > > And then go back to the drawing board to fix the corruption reported by > syzkaller. I'll revert these two. -- Jens Axboe