From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none X-Greylist: delayed 8973 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 24 Nov 2023 15:41:32 PST Received: from 4.mo550.mail-out.ovh.net (4.mo550.mail-out.ovh.net [46.105.76.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7C210F6 for ; Fri, 24 Nov 2023 15:41:32 -0800 (PST) Received: from director7.ghost.mail-out.ovh.net (unknown [10.109.143.109]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 9276F275E5 for ; Fri, 24 Nov 2023 21:11:57 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-wmx76 (unknown [10.110.208.112]) by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 225AE1FDEC; Fri, 24 Nov 2023 21:11:57 +0000 (UTC) Received: from RCM-web2.webmail.mail.ovh.net ([176.31.232.109]) by ghost-submission-6684bf9d7b-wmx76 with ESMTPSA id E+cDB50RYWVpxBkAOqy2KQ (envelope-from ); Fri, 24 Nov 2023 21:11:57 +0000 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 24 Nov 2023 22:11:56 +0100 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Miquel Raynal Cc: Greg Kroah-Hartman , Srinivas Kandagatla , linux-kernel@vger.kernel.org, Michael Walle , Thomas Petazzoni , stable@vger.kernel.org, Luca Ceresoli Subject: Re: [PATCH] nvmem: Do not expect fixed layouts to grab a layout driver In-Reply-To: <20231124193814.360552-1-miquel.raynal@bootlin.com> References: <20231124193814.360552-1-miquel.raynal@bootlin.com> User-Agent: Roundcube Webmail/1.4.15 Message-ID: <1d895bbb7e892507195db9ab81f88f54@milecki.pl> X-Sender: rafal@milecki.pl X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 1269170673624656716 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrudehhedgudegiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeggfffhvfevufgjfhgfkfigihgtgfesthekjhdttderjeenucfhrhhomheptfgrfhgrlhcuofhilhgvtghkihcuoehrrghfrghlsehmihhlvggtkhhirdhplheqnecuggftrfgrthhtvghrnheptdekvedtkeegteefheeifefhueetvedvvddvudekgfeihfdufefgleduheelgfevnecuffhomhgrihhnpehophgvnhifrhhtrdhorhhgnecukfhppeduvdejrddtrddtrddupdefuddruddurddvudekrddutdeipddujeeirdefuddrvdefvddruddtleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehrrghfrghlsehmihhlvggtkhhirdhplheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepshhtrggslhgvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth On 2023-11-24 20:38, Miquel Raynal wrote: > Two series lived in parallel for some time, which led to this > situation: > - The nvmem-layout container is used for dynamic layouts > - We now expect fixed layouts to also use the nvmem-layout container > but > this does not require any additional driver, the support is built-in > the > nvmem core. > > Ensure we don't refuse to probe for wrong reasons. I pushed a pretty much identical patch to OpenWrt (I just forgot of_node_put()): commit 61f674df4f0c ("kernel: nvmem: fix "fixed-layout" & support "mac-base""): https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=61f674df4f0ce2b1c53b0b7f6b0c1d03d99838c0 It's in use since July and seems to do the trick just fine. Thanks for submitting this fix. > Fixes: 27f699e578b1 ("nvmem: core: add support for fixed cells > *layout*") > Cc: stable@vger.kernel.org > Reported-by: Luca Ceresoli > Signed-off-by: Miquel Raynal Tested-by: Rafał Miłecki -- Rafał Miłecki