From: Krzysztof Kozlowski <krzk@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Josh Law <joshlaw48@gmail.com>, stable@vger.kernel.org
Subject: Re: Backport request
Date: Thu, 23 Apr 2026 09:02:11 +0200 [thread overview]
Message-ID: <1ee4f907-1eca-473d-93b2-c99d733a432b@kernel.org> (raw)
In-Reply-To: <2026042320-husband-brought-c7c7@gregkh>
On 23/04/2026 08:46, Greg KH wrote:
> On Thu, Apr 23, 2026 at 08:39:29AM +0200, Krzysztof Kozlowski wrote:
>> On 23/04/2026 06:55, Greg KH wrote:
>>> On Wed, Apr 22, 2026 at 06:04:50PM +0100, Josh Law wrote:
>>>> Hello, I would like backports for
>>>>
>>>> Mainline hashes:
>>>>
>>>> https://github.com/torvalds/linux/commit/8cdf30813ea8ce881cecc08664144416dbdb3e16
>>>>
>>>> https://github.com/torvalds/linux/commit/9003ec6f7f394943880618737d797a9f257e6e1e
>>>
>>> None of those have showed up in an actual release yet, so why should
>>> they be included "early"?
>>
>> None of the code was tested as Josh Law lied more than once about tests
>> [1] or laughed at us when we asked for testing:
>>
>> "laugh my ass out and your test cases, absolutely ill add some test
>> cases" [2]
>>
>> and then Josh Law was pushing his patches to get merged:
>>
>> "This most definitely needs to be merged." [3]
>> "Yeah in my opinion I think this may need to be merged.. if you would
>> like I can add the NOWARN" [4]
>>
>> And now we see a push for these commits to stable!
>>
>> Nothing from Josh Law should be going to stable trees, because nothing
>> was ever tested.
>
> Makes sense, is anyone going to send reverts for these?
Untested does not mean yet incorrect, so not sure if we need to act on
already accepted commits getting to stable. Especially that for a revert
I would need to provide some stronger arguments, IMO. Easier to drop
from the queue in review.
OTOH, if the actor is not trusted, a past correct patch is not a
positive indication for another patch. Untrusted, for whatever reason,
actor can write correct patches for some time...
When untrusted person pushes why things are not in stable, it feels to
me like a warning sign.
>
> I'll drop them from my "to review" stable queues, that includes the
> following:
>
> mm/damon/sysfs: check contexts->nr in repeat_call_fn
> mm/damon/sysfs: fix param_ctx leak on damon_sysfs_new_test_ctx() failure
> mm/damon/sysfs: check contexts->nr before accessing contexts_arr[0]
> lib/ts_bm: fix integer overflow in pattern length calculation
> lib/ts_kmp: fix integer overflow in pattern length calculation
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-23 7:02 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 17:04 Backport request Josh Law
2026-04-23 4:55 ` Greg KH
2026-04-23 6:39 ` Krzysztof Kozlowski
2026-04-23 6:46 ` Greg KH
2026-04-23 7:02 ` Krzysztof Kozlowski [this message]
2026-04-23 7:56 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2025-01-18 9:10 backport request Ard Biesheuvel
2025-01-18 9:27 ` Greg KH
2024-11-16 11:08 Backport request Hemdan, Hagar Gamal Halim
2024-11-16 13:51 ` Greg KH
2024-11-12 10:31 Hemdan, Hagar Gamal Halim
2024-11-15 5:10 ` Greg KH
2024-05-29 8:50 backport request Ard Biesheuvel
2024-06-06 13:10 ` Greg KH
2024-06-07 8:43 ` Ard Biesheuvel
2024-06-07 10:23 ` Greg KH
2024-06-07 10:25 ` Ard Biesheuvel
2024-06-07 10:27 ` Ard Biesheuvel
2024-06-07 10:46 ` Greg KH
2024-06-07 10:49 ` Ard Biesheuvel
2024-05-16 10:16 Backport request Hemdan, Hagar Gamal Halim
2024-05-22 15:45 ` Greg KH
2023-08-01 7:17 Hemdan, Hagar Gamal Halim
2023-08-01 7:24 ` Greg KH
2023-07-25 11:13 backport request Ard Biesheuvel
2023-07-25 11:17 ` Ard Biesheuvel
2023-07-25 12:29 ` Greg KH
2023-07-25 12:51 ` Ard Biesheuvel
2023-07-25 13:21 ` Greg KH
2023-07-25 13:25 ` Ard Biesheuvel
2023-07-25 13:41 ` Greg KH
2023-07-25 13:48 ` Ard Biesheuvel
2023-07-27 10:59 ` Greg KH
2022-08-24 11:20 Backport request Juergen Gross
2022-08-24 12:10 ` Greg Kroah-Hartman
2022-08-24 13:52 ` Juergen Gross
2022-08-25 11:59 ` Greg Kroah-Hartman
2020-12-15 16:02 Daniel Vetter
2020-12-19 12:42 ` Greg KH
2020-12-19 13:56 ` Daniel Vetter
2019-07-16 22:08 Thomas Gleixner
2019-07-16 23:01 ` Greg KH
2019-07-17 23:38 ` Sasha Levin
2019-07-18 7:57 ` Thomas Gleixner
2018-02-28 13:56 Corey Minyard
2018-02-28 14:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ee4f907-1eca-473d-93b2-c99d733a432b@kernel.org \
--to=krzk@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joshlaw48@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox