From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 417231DFE23 for ; Wed, 29 Jan 2025 17:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738172726; cv=none; b=CzXCbp4ZmxL8veRhTK1qabvgvL0mY3jcHRb5VxJuzwmUAns3jZHcUg/NYg56o0WdA2VbnJ3uH01sWK/00KRCXC8GzMclUcaRH6vb1LFtAy9ZzAp15lyWUW/kwyKj3Y0UqcFzEvC2e4JRMkssGsPRTfpw4atnYQyiLQ9xthsEWz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738172726; c=relaxed/simple; bh=NULsOQama/hTdTz3oEBBU+fvsMlvrdp8LfoiNvuR2Gs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BLrWSVM/YdwZxE7+NJI9+s2g5jNf9rPRmhLwScXufI98H2PAd2LGR1hOP1nFEr+zfEiEodI9x1ohdWjFIP2G1FlK/kmD1NXrKfzWwIY+Y+OR2MC0k8VWymLpm9cs40bBWcgkbqa9jbJhHaLXPC6c6DeLpGaQkSqM5Ylptm9KaZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Vz5yfqtS; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Vz5yfqtS" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-2b199bb8af9so491356fac.1 for ; Wed, 29 Jan 2025 09:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738172724; x=1738777524; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=gZlgC15WVSUVGLOS7Ms7f7JNNK9Z91KQ99S3O87JW2E=; b=Vz5yfqtSVehMVi6hOJMKpQq8vfyVQX3ggeGRVgzKzFiWq+QSgcz1/B8xE6P8DoiFgv ev9jRDo0j8/ZyLexm/zErBrB6NA2YpFB9izJqBvikv11L1d8262/MldXq8BlYRP7Pvzj UMPeADL/mzu8uLyg8A8cW2irLs+K3njVA/ZTo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738172724; x=1738777524; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gZlgC15WVSUVGLOS7Ms7f7JNNK9Z91KQ99S3O87JW2E=; b=R65wgRjIifwDRvK7CtFCpvDBgrukO57G76iGLEe7395+kNWWg+qVad39aFwnABukAE qXcz3DHJnFBdPCmVjq6GLwicRBctbQ2ovR2YZvWS11Y4dq9T77XVKwSjJCGfqV9Q6lJK 1QC/0Rd82zBL6IdfxZbkMydUvjQXtGxpH3XVukbejug9ayGJiIiIfHcWbQVDUYf0hxKO yVPD5WKfDWSVn9NVY1hfnmXdNNNlDWJDYLKFJSaUBuyYFze8TRamR17FAumd5AG8Q2Cc 5KXCzonvfP5KIq9Yx5ychrgsauyKtz+qsXrWuamQcw6ZKW/3/Qiij75Ulqlujc/Gkvbl qDUA== X-Gm-Message-State: AOJu0YziOZ+rvUCHTScKk30BavEMGkNeRPXxSMcQvv7Ta5jRB/yHv6eJ ZdAhRvKBcfx1QHl8Scf3qBborTGRVNVVOszC8Y0DyIaE0x0KLowTnxkxsggRUQ== X-Gm-Gg: ASbGnct1d6oPAZdHGn1pfmeRHxxJTcVTR1G/lGta3bnkHKZaiMnn7Iza4T+egsemF7e bRmC76aI1mOFjQs8rojEpFCjSzMhCqaR8+c8iu0J+NuH7hwiO155rPM8RjCdf70i0Q5XleKeb+U qyBci57YtCQLC2SYX9WTXE4FeINOsQxD49rEZpEK/rGkjT9BUY4354DP/DWr8ib+qHs4jKoBFNC kN/rsMDA2+T8byZljWKeuEDcuuUMuv4qSUAuEzuBXFOHoqRE6PwvNxdGlYYpO2x2ZP0cK4ew5QH lSU6FVXKtG4FKfJOOosIatGwotvFWm79t8/zZVUoVThD0WNjWZZP6FU= X-Google-Smtp-Source: AGHT+IHwzS4J+111BxXMG7S5YWgNJO4L53ui5ETZhZIQUxanmm0EXiiJAU+I6/ScpTA/4dq8zumJOQ== X-Received: by 2002:a05:6871:4006:b0:2ab:99ac:250e with SMTP id 586e51a60fabf-2b34ff151aemr154504fac.11.1738172723629; Wed, 29 Jan 2025 09:45:23 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b28f1daff6sm4498878fac.30.2025.01.29.09.45.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 09:45:22 -0800 (PST) Message-ID: <1fc6d5c8-80ec-4d6b-bc14-c584d89c15b4@broadcom.com> Date: Wed, 29 Jan 2025 09:45:20 -0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: mm: account for hotplug memory when randomizing the linear region To: Greg KH , Florian Fainelli Cc: stable@vger.kernel.org, Ard Biesheuvel , Anshuman Khandual , Will Deacon , Steven Price , Robin Murphy , Catalin Marinas , Baruch Siach , Petr Tesarik , Mark Rutland , Joey Gouly , "Mike Rapoport (IBM)" , Yang Shi , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , open list References: <20250109165419.1623683-1-florian.fainelli@broadcom.com> <20250109165419.1623683-2-florian.fainelli@broadcom.com> <62786457-d4a1-4861-8bec-7e478626f4db@broadcom.com> <2025011247-enable-freezing-ffa2@gregkh> <27bbea11-61fa-4f41-8b39-8508f2d2e385@broadcom.com> <2025012002-tactics-murky-aaab@gregkh> <41550c7f-1313-41b4-aa2e-cb4809ad68c2@broadcom.com> <2025012938-abreast-explain-f5f7@gregkh> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <2025012938-abreast-explain-f5f7@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/29/25 01:17, Greg KH wrote: > On Mon, Jan 20, 2025 at 08:33:12AM -0800, Florian Fainelli wrote: >> >> >> On 1/20/2025 5:59 AM, Greg KH wrote: >>> On Mon, Jan 13, 2025 at 07:44:50AM -0800, Florian Fainelli wrote: >>>> >>>> >>>> On 1/12/2025 3:54 AM, Greg KH wrote: >>>>> On Thu, Jan 09, 2025 at 09:01:13AM -0800, Florian Fainelli wrote: >>>>>> On 1/9/25 08:54, Florian Fainelli wrote: >>>>>>> From: Ard Biesheuvel >>>>>>> >>>>>>> commit 97d6786e0669daa5c2f2d07a057f574e849dfd3e upstream >>>>>>> >>>>>>> As a hardening measure, we currently randomize the placement of >>>>>>> physical memory inside the linear region when KASLR is in effect. >>>>>>> Since the random offset at which to place the available physical >>>>>>> memory inside the linear region is chosen early at boot, it is >>>>>>> based on the memblock description of memory, which does not cover >>>>>>> hotplug memory. The consequence of this is that the randomization >>>>>>> offset may be chosen such that any hotplugged memory located above >>>>>>> memblock_end_of_DRAM() that appears later is pushed off the end of >>>>>>> the linear region, where it cannot be accessed. >>>>>>> >>>>>>> So let's limit this randomization of the linear region to ensure >>>>>>> that this can no longer happen, by using the CPU's addressable PA >>>>>>> range instead. As it is guaranteed that no hotpluggable memory will >>>>>>> appear that falls outside of that range, we can safely put this PA >>>>>>> range sized window anywhere in the linear region. >>>>>>> >>>>>>> Signed-off-by: Ard Biesheuvel >>>>>>> Cc: Anshuman Khandual >>>>>>> Cc: Will Deacon >>>>>>> Cc: Steven Price >>>>>>> Cc: Robin Murphy >>>>>>> Link: https://lore.kernel.org/r/20201014081857.3288-1-ardb@kernel.org >>>>>>> Signed-off-by: Catalin Marinas >>>>>>> Signed-off-by: Florian Fainelli >>>>>> >>>>>> Forgot to update the patch subject, but this one is for 5.10. >>>>> >>>>> You also forgot to tell us _why_ this is needed :( >>>> >>>> This is explained in the second part of the first paragraph: >>>> >>>> The consequence of this is that the randomization offset may be chosen such >>>> that any hotplugged memory located above memblock_end_of_DRAM() that appears >>>> later is pushed off the end of the linear region, where it cannot be >>>> accessed. >>>> >>>> We use both memory hotplug and KASLR on our systems and that's how we >>>> eventually found out about the bug. >>> >>> And you still have 5.10.y ARM64 systems that need this? Why not move to >>> a newer kernel version already? >> >> We still have ARM64 systems running 5.4 that need this, and the same bug >> applies to 5.10 that we used to support but dropped in favor of 5.15/6.1. >> Those are the kernel versions used by Android, and Android TV in particular, >> so it's kind of the way it goes for us. >> >>> >>> Anyway, I need an ack from the ARM64 maintainers that this is ok to >>> apply here before I can take it. >> >> Just out of curiosity, the change is pretty innocuous and simple to review, >> why the extra scrutiny needed here? > > Why shouldn't the maintainers review a proposed backport patch for core > kernel code that affects everyone who uses that arch? They should, but they are not, we can keep sending messages like those in the hope that someone does, but clearly that is not working at the moment. This patch cherry picked cleanly into 5.4 and 5.10 maybe they just trust whoever submit stable bugfixes to have done their due diligence, too, I don't know how to get that moving now but it fixes a real problem we observed. -- Florian