From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Tue, 3 Jan 2012 08:42:58 -0800
From: Greg KH <gregkh@suse.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	rtc-linux@googlegroups.com, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
	John Stultz <john.stultz@linaro.org>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Rabin Vincent <rabin.vincent@stericsson.com>,
	"Antonio-M. Corbi Bellot" <antonio.corbi@ua.es>,
	Marco Santos <marco.santos@waynext.com>,
	Christophe Vu-Brugier <cvubrugier@yahoo.fr>
Subject: Re: [096/104] rtc: Disable the alarm in the hardware
Message-ID: <20120103164258.GA26638@suse.de>
References: <20111207161246.GA10995@kroah.com>
 <20111207161222.676101253@clark.kroah.org>
 <20120103162720.GA22050@elie.hsd1.il.comcast.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120103162720.GA22050@elie.hsd1.il.comcast.net>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, Jan 03, 2012 at 10:27:20AM -0600, Jonathan Nieder wrote:
> Hi Greg,
> 
> Greg KH wrote:
> 
> > 3.1-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Rabin Vincent <rabin.vincent@stericsson.com>
> >
> > commit c0afabd3d553c521e003779c127143ffde55a16f upstream.
> >
> > Currently, the RTC code does not disable the alarm in the hardware.
> >
> > This means that after a sequence such as the one below (the files are in the
> > RTC sysfs), the box will boot up after 2 minutes even though we've
> > asked for the alarm to be turned off.
> [...]
> > Fix this by disabling the alarm when there are no timers to run.
> 
> Seems to cause a regression.  On the affected kernels (e.g., 3.1.5,
> 3.1.6, and 3.2-rc7) the patch has exactly the opposite of what you'd
> expect --- the affected machines automatically power on a few minutes
> after shutdown if and only if the patch is applied.
> 
> The affected machines all seem to be Toshiba Portege laptops.
> 
>  Antonio-M. Corbi Bellot: Toshiba Portege R500
>  Marco Santos: Toshiba Portege Z830
>  Christophe Vu-Brugier: Toshiba Portege R830
> 
> Christophe tried reverting the above patch and the symptoms went away.
> See http://bugs.debian.org/652869 for details.  Please consider
> reverting the patch from stable until this is resolved.

Is it also reverted (or fixed), in Linus's tree as well?

thanks,

greg k-h