From: Greg KH <greg@kroah.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
stable@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Petr Matousek <pmatouse@redhat.com>,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
James Bottomley <JBottomley@parallels.com>
Subject: Re: [PATCH stable 3/4] block: fail SCSI passthrough ioctls on partition devices
Date: Wed, 25 Jan 2012 16:19:26 -0800 [thread overview]
Message-ID: <20120126001926.GA1058@kroah.com> (raw)
In-Reply-To: <4F1EAA6A.6020207@redhat.com>
On Tue, Jan 24, 2012 at 01:56:10PM +0100, Paolo Bonzini wrote:
> On 01/18/2012 05:04 PM, Ben Hutchings wrote:
> >> There is harm. You'll be blacklisting also the standard block device
> >> ioctls, and those won't work on 32-on-64 anymore. A system with 32-bit
> >> userland will likely not boot anymore.
> >
> >It does (yes, I tested that myself now). The standard block device
> >ioctls are handled without calling the driver's compat_ioctl.
>
> What about the non-compat path when done by non-root?
>
> * Does BLKROSET still return EACCES when run by non-root and without
> CAP_SYS_ADMIN? I suspect your patch is changing it to EINVAL.
>
> * Does BLKFLSBUF work when run by non-root but with CAP_SYS_ADMIN?
I'm confused here as well.
Can someone please send me the proper patch that I need to apply to
resolve this issue on the 2.6.32.y kernel?
thanks,
greg k-h
next prev parent reply other threads:[~2012-01-26 0:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1326380489-9044-1-git-send-email-pbonzini@redhat.com>
[not found] ` <1326380489-9044-3-git-send-email-pbonzini@redhat.com>
2012-01-14 23:43 ` [PATCH v2 2/3] block: fail SCSI passthrough ioctls on partition devices Linus Torvalds
2012-01-16 8:51 ` Paolo Bonzini
2012-01-17 3:58 ` Ben Hutchings
2012-01-17 4:06 ` [PATCH stable 1/4] kernel.h: add printk_ratelimited and pr_<level>_rl Ben Hutchings
2012-01-17 4:06 ` [PATCH stable 2/4] block: add and use scsi_blk_cmd_ioctl Ben Hutchings
2012-01-17 4:07 ` [PATCH stable 3/4] block: fail SCSI passthrough ioctls on partition devices Ben Hutchings
2012-01-17 9:55 ` Paolo Bonzini
2012-01-18 4:47 ` Ben Hutchings
2012-01-18 9:00 ` Paolo Bonzini
2012-01-18 16:04 ` Ben Hutchings
2012-01-24 12:56 ` Paolo Bonzini
2012-01-26 0:19 ` Greg KH [this message]
2012-01-26 18:28 ` Greg KH
2012-01-17 4:07 ` [PATCH stable 4/4] dm: do not forward ioctls from logical volumes to the underlying device Ben Hutchings
2012-01-17 20:03 ` [PATCH v2 2/3] block: fail SCSI passthrough ioctls on partition devices Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126001926.GA1058@kroah.com \
--to=greg@kroah.com \
--cc=JBottomley@parallels.com \
--cc=axboe@kernel.dk \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pmatouse@redhat.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).