From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20120205220952.019376250@pcw.home.local> Date: Sun, 05 Feb 2012 23:10:49 +0100 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Johannes Berg , Balbir Singh , Linus Torvalds , =?ISO-8859-15?q?Moritz=20M=FChlenhoff?= , Greg KH Subject: [PATCH 60/91] Make TASKSTATS require root access In-Reply-To: <0635750f5f06ed2ca212b91fcb5c4483@local> Sender: linux-kernel-owner@vger.kernel.org List-ID: 2.6.27-longterm review patch. If anyone has any objections, please let us know. ------------------ commit 1a51410abe7d0ee4b1d112780f46df87d3621043 upstream. Ok, this isn't optimal, since it means that 'iotop' needs admin capabilities, and we may have to work on this some more. But at the same time it is very much not acceptable to let anybody just read anybody elses IO statistics quite at this level. Use of the GENL_ADMIN_PERM suggested by Johannes Berg as an alternative to checking the capabilities by hand. Reported-by: Vasiliy Kulikov Cc: Johannes Berg Acked-by: Balbir Singh Signed-off-by: Linus Torvalds Cc: Moritz M�hlenhoff Signed-off-by: Greg Kroah-Hartman --- kernel/taskstats.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) Index: longterm-2.6.27/kernel/taskstats.c =================================================================== --- longterm-2.6.27.orig/kernel/taskstats.c 2012-02-05 22:34:33.153915196 +0100 +++ longterm-2.6.27/kernel/taskstats.c 2012-02-05 22:34:43.419915481 +0100 @@ -574,6 +574,7 @@ .cmd = TASKSTATS_CMD_GET, .doit = taskstats_user_cmd, .policy = taskstats_cmd_get_policy, + .flags = GENL_ADMIN_PERM, }; static struct genl_ops cgroupstats_ops = {