From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: raphael@buro.asia
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
stable@vger.kernel.org, Suresh Siddha <suresh.b.siddha@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] i387: stable kernel backport
Date: Thu, 23 Feb 2012 11:36:20 -0800 [thread overview]
Message-ID: <20120223193620.GA16477@kroah.com> (raw)
In-Reply-To: <e709c3b5c5b2aa6e6a9d049f3af857e3@buro.asia>
On Thu, Feb 23, 2012 at 10:41:57AM +0800, raphael@buro.asia wrote:
> On 23.02.2012 10:55, Linus Torvalds wrote:
> >On Wed, Feb 22, 2012 at 5:47 PM, <raphael@buro.asia> wrote:
> >>
> >>Thank you for backporting this patchset to -stable. FWIW, the
> >>test machine I
> >>had been working with has an uptime of 4 days now, with the
> >>patchset in
> >>attachment applied on top of 3.2.6, so if it were unpractical to
> >>trim it
> >>down further you can find solace in that it does not break anything.
> >
> >Hmm. The patches in your attachements are whitespace-damaged. I was
> >going to apply that series and see what the difference was to my
> >minimal trial, but with the corruption that isn't possible.
> >
> >I didn't find anything obviously wrong in my series, so..
> >
> >Could you send the patches you used for your backport with the
> >whitespace fixed, and preferably with the patch numbering explained?
>
> The numbering is just so I can apply the patches in the right order
> with a for loop in the packaging script. The missing 7* was the
> experimental patches we tried which moved has_fpu in the thread_info
> struct (which did not work).
>
> The patchset is simply made of:
> be98c2cdb15ba26148cd2bd58a857d4f7759ed38 (unmodified)
> 5b1cbac37798805c1fee18c8cebe5c0a13975b17 (")
> c38e23456278e967f094b08247ffc3711b1029b2 (")
> 15d8791cae75dca27bfda8ecfe87dca9379d6bb0 (")
> b6c66418dcad0fcf83cd1d0a39482db37bf4fc41 (")
> 6d59d7a9f5b723a7ac1925c136e93ec83c0c3043 (")
> b3b0870ef3ffed72b92415423da864f440f57ad6 (")
These all applied fine, I've queued them up so far.
> 4903062b5485f0e2c286a23b44c9b59d9b017d53: this one requires a slight
> modification:
> -#define safe_address (kstat_cpu(0).cpustat.user)
> instead of:
> -#define safe_address
> (__get_cpu_var(kernel_cpustat).cpustat[CPUTIME_USER])
Hm, for 3.0-stable, yes, that's all that seems to be needed, but for
3.2-stable, something is odd here, there's some changes that are missing
here to get this correct (odds are you didn't test this on a AMD
processor, that's the odd portion of the merge.)
I'll dig into this some more, maybe we need another patch here...
greg k-h
next prev parent reply other threads:[~2012-02-23 19:36 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 20:54 [PATCH 0/5] i387: stable kernel backport Linus Torvalds
2012-02-22 20:56 ` [PATCH 1/5] i387: math_state_restore() isn't called from asm Linus Torvalds
2012-02-22 20:56 ` [PATCH 2/5] i387: make irq_fpu_usable() tests more robust Linus Torvalds
2012-02-22 20:57 ` [PATCH 3/5] i387: fix x86-64 preemption-unsafe user stack save/restore Linus Torvalds
2012-02-22 20:58 ` [PATCH 4/5] i387: move TS_USEDFPU clearing out of __save_init_fpu and into callers Linus Torvalds
2012-02-22 20:59 ` [PATCH 5/5] i387: move TS_USEDFPU flag from thread_info to task_struct Linus Torvalds
2012-02-22 21:02 ` [PATCH 0/5] i387: stable kernel backport H. Peter Anvin
2012-02-22 21:19 ` Greg Kroah-Hartman
2012-02-22 21:29 ` Linus Torvalds
2012-02-22 21:30 ` Linus Torvalds
2012-02-22 21:32 ` Greg Kroah-Hartman
2012-02-23 20:09 ` Greg Kroah-Hartman
2012-02-23 20:29 ` H. Peter Anvin
2012-02-23 20:48 ` Greg Kroah-Hartman
2012-02-23 20:51 ` H. Peter Anvin
2012-02-23 21:10 ` Greg Kroah-Hartman
2012-02-23 21:52 ` Willy Tarreau
2012-02-23 22:11 ` Linus Torvalds
2012-02-23 22:27 ` Willy Tarreau
2012-02-23 22:38 ` Linus Torvalds
2012-02-23 22:48 ` H. Peter Anvin
2012-02-23 22:52 ` Willy Tarreau
2012-02-23 22:55 ` H. Peter Anvin
2012-02-23 23:04 ` Willy Tarreau
2012-02-23 22:49 ` Willy Tarreau
2012-02-23 22:59 ` Greg Kroah-Hartman
2012-02-23 23:05 ` H. Peter Anvin
2012-02-23 23:16 ` Greg Kroah-Hartman
2012-02-23 23:18 ` H. Peter Anvin
2012-02-23 23:19 ` Suresh Siddha
2012-02-23 23:54 ` Greg Kroah-Hartman
2012-02-23 23:59 ` H. Peter Anvin
2012-02-24 0:47 ` H. Peter Anvin
2012-02-22 22:34 ` H. Peter Anvin
2012-02-22 22:45 ` H. Peter Anvin
2012-02-22 23:15 ` Linus Torvalds
2012-02-22 23:31 ` Linus Torvalds
2012-02-23 0:14 ` H. Peter Anvin
2012-02-23 0:25 ` Linus Torvalds
2012-02-23 0:37 ` Greg Kroah-Hartman
2012-02-23 1:47 ` raphael
2012-02-23 2:55 ` Linus Torvalds
2012-02-23 2:41 ` raphael
2012-02-23 3:37 ` Linus Torvalds
2012-02-23 18:15 ` Greg Kroah-Hartman
2012-02-23 19:36 ` Greg Kroah-Hartman [this message]
2012-02-23 19:41 ` Linus Torvalds
2012-02-23 19:50 ` Greg Kroah-Hartman
2012-02-23 19:55 ` Greg Kroah-Hartman
2012-02-23 20:02 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223193620.GA16477@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raphael@buro.asia \
--cc=stable@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).