From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 28 Feb 2012 17:03:11 -0800 From: Dmitry Torokhov To: Greg KH Cc: Manoj Iyer , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook Message-ID: <20120229010311.GA11492@core.coreip.homeip.net> References: <1330475770-4153-1-git-send-email-manoj.iyer@canonical.com> <1330475770-4153-2-git-send-email-manoj.iyer@canonical.com> <20120229004604.GB21093@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120229004604.GB21093@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Tue, Feb 28, 2012 at 04:46:04PM -0800, Greg KH wrote: > On Tue, Feb 28, 2012 at 06:36:10PM -0600, Manoj Iyer wrote: > > HP ProBooks do not send a key release for brightness keys, as a > > result, brightness does not move up/down when the brightness key > > is held down. This quirk makes the brightness keys on HP ProBooks > > typematic. > > > > Signed-off-by: Manoj Iyer > > --- > > drivers/input/keyboard/atkbd.c | 16 ++++++++++++++++ > > 1 files changed, 16 insertions(+), 0 deletions(-) > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > Also, this should be handled from userspace by having usev write to /sys/bus/serio/devices/serioX/force_release attribute on affected boxes. -- Dmitry