From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 1 Apr 2012 17:11:08 +0100 From: Ken Moffat To: Greg KH Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Matthew Garrett , Jesse Barnes Subject: Re: [ 06/41] PCI: ignore pre-1.1 ASPM quirking when ASPM is disabled Message-ID: <20120401161108.GA6448@milliways> References: <20120316233829.GA14022@kroah.com> <20120316233811.136320350@linuxfoundation.org> <20120331032356.GA6664@milliways> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120331032356.GA6664@milliways> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Sat, Mar 31, 2012 at 04:23:56AM +0100, Ken Moffat wrote: [ update : 3.4.0-rc1 boots without reverting this ] > On Fri, Mar 16, 2012 at 04:38:16PM -0700, Greg KH wrote: > > 3.2-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Matthew Garrett > > > > commit 4949be16822e92a18ea0cc1616319926628092ee upstream. > > > > Right now we won't touch ASPM state if ASPM is disabled, except in the case > > where we find a device that appears to be too old to reliably support ASPM. > > Right now we'll clear it in that case, which is almost certainly the wrong > > thing to do. The easiest way around this is just to disable the blacklisting > > when ASPM is disabled. > > > > Signed-off-by: Matthew Garrett > > Signed-off-by: Jesse Barnes > > Signed-off-by: Greg Kroah-Hartman > > > > Sorry for the late response, but I bought a new machine this week > (low-end i3) and this has bitten me. I prepared a "generic" x86_64 > kernel using 3.2.9, which I hoped would be good enough to get me > started, and later prepared another using 3.3.0. Long story short - > 3.2.9 was adequate, 3.3.0 crashes early in boot (before switching > from the 80x25 console to kms). All the interesting part has > scrolled off the screen, and it's too early to get logged. > [...] > Trial and error showed this commit seemed to be the > problem. > > I then reverted this commit from 3.3.0, and took my amended .config > which works adequately in vanilla 3.2.8. I'm now running that. > BUT, for 3.4.0-rc1 I don't need to revert it - just went with the defaults for additions in menuconfig, and it boots fine. Maybe something else needs to be backported ? ken -- das eine Mal als Trag�die, das andere Mal als Farce