Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

[Greg KH]

On Mon, Apr 02, 2012 at 06:47:02PM -0400, Konrad Rzeszutek Wilk wrote:
> Hey Greg,
> 
> The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC stable@kernel.org
> but it breaks Xen - we are working to fix it in 3.4, but the fix for it
> does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that
> I don't know if you are comfortable putting in stable tree.
> 

I have no idea what that git commit id referrs to, as it's not in
Linus's tree at the moment.

Care to give me a subject?  diffstat?  Some kind of hint?

And note, you forgot to send this to the stable@vger.kernel.org list,
where the other stable kernel maintainers live, please do so next time.

thanks,

greg k-h

Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

[Suresh Siddha]

On Mon, 2012-04-02 at 16:27 -0700, Greg KH wrote:
> On Mon, Apr 02, 2012 at 06:47:02PM -0400, Konrad Rzeszutek Wilk wrote:
> > Hey Greg,
> > 
> > The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC stable@kernel.org
> > but it breaks Xen - we are working to fix it in 3.4, but the fix for it
> > does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that
> > I don't know if you are comfortable putting in stable tree.
> > 
> 
> I have no idea what that git commit id referrs to, as it's not in
> Linus's tree at the moment.
> 
> Care to give me a subject?  diffstat?  Some kind of hint?

Greg, Konrad is referring to:

commit 73d63d038ee9f769f5e5b46792d227fe20e442c5
Author: Suresh Siddha <suresh.b.siddha@intel.com>
Date:   Mon Mar 12 11:36:33 2012 -0700

    x86/ioapic: Add register level checks to detect bogus io-apic entries

With out this commit, if the bios lists bogus io-apic's, then we will
see some error messages ("Unable to reset IRR for apic")during linux
boot which are benign. But as this patch breaks Xen, I am ok if these
don't get applied to 'stable'. Also I think it is Ingo who added the
'stable' tag. Ingo, are you ok with this?

For the mainline, we have queued more patches to fix the Xen breakage.

thanks,
suresh

> 
> And note, you forgot to send this to the stable@vger.kernel.org list,
> where the other stable kernel maintainers live, please do so next time.
> 
> thanks,
> 
> greg k-h

Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

[Greg KH]

On Mon, Apr 02, 2012 at 04:43:05PM -0700, Suresh Siddha wrote:
> On Mon, 2012-04-02 at 16:27 -0700, Greg KH wrote:
> > On Mon, Apr 02, 2012 at 06:47:02PM -0400, Konrad Rzeszutek Wilk wrote:
> > > Hey Greg,
> > > 
> > > The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC stable@kernel.org
> > > but it breaks Xen - we are working to fix it in 3.4, but the fix for it
> > > does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that
> > > I don't know if you are comfortable putting in stable tree.
> > > 
> > 
> > I have no idea what that git commit id referrs to, as it's not in
> > Linus's tree at the moment.
> > 
> > Care to give me a subject?  diffstat?  Some kind of hint?
> 
> Greg, Konrad is referring to:
> 
> commit 73d63d038ee9f769f5e5b46792d227fe20e442c5

Ok, then where did the 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 number
come from?  And where was I supposed to be able to determine what it is
pointing to?

Come on people...

> Author: Suresh Siddha <suresh.b.siddha@intel.com>
> Date:   Mon Mar 12 11:36:33 2012 -0700
> 
>     x86/ioapic: Add register level checks to detect bogus io-apic entries
> 
> With out this commit, if the bios lists bogus io-apic's, then we will
> see some error messages ("Unable to reset IRR for apic")during linux
> boot which are benign. But as this patch breaks Xen, I am ok if these
> don't get applied to 'stable'. Also I think it is Ingo who added the
> 'stable' tag. Ingo, are you ok with this?

What stable trees did this already go into in the releases today?

You need to tell me what I need to revert here, SPECIFICALLY, and in
what tree, if needed, otherwise I have no idea what is going on, sorry,
I can't read minds.

> For the mainline, we have queued more patches to fix the Xen breakage.

And what is that supposed to mean to me?

Again, help me out here, this is making no sense at all.

How am I supposed to "not apply" a patch that I have never heard of?
And how am I supposed to "not apply" a patch that I have already
applied?

How about you all start over from the beginning and tell me EXACTLY what
you want me to do here, because I sure as heck don't know what is going
on...

confused,

greg k-h

Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

[Konrad Rzeszutek Wilk]

On Mon, Apr 02, 2012 at 04:49:04PM -0700, Greg KH wrote:
> On Mon, Apr 02, 2012 at 04:43:05PM -0700, Suresh Siddha wrote:
> > On Mon, 2012-04-02 at 16:27 -0700, Greg KH wrote:
> > > On Mon, Apr 02, 2012 at 06:47:02PM -0400, Konrad Rzeszutek Wilk wrote:
> > > > Hey Greg,
> > > > 
> > > > The git commit 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 has CC stable@kernel.org
> > > > but it breaks Xen - we are working to fix it in 3.4, but the fix for it
> > > > does some architectual changes (136d249ef7dbf0fefa292082cc40be1ea864cbd6) that
> > > > I don't know if you are comfortable putting in stable tree.
> > > > 
> > > 
> > > I have no idea what that git commit id referrs to, as it's not in
> > > Linus's tree at the moment.
> > > 
> > > Care to give me a subject?  diffstat?  Some kind of hint?
> > 
> > Greg, Konrad is referring to:
> > 
> > commit 73d63d038ee9f769f5e5b46792d227fe20e442c5
> 
> Ok, then where did the 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 number
> come from?  And where was I supposed to be able to determine what it is
> pointing to?

Hm, somehow that is the git commit I saw, but it probably was b/c it got
cherrypicked in my testing tree.
> 
> Come on people...
> 
> > Author: Suresh Siddha <suresh.b.siddha@intel.com>
> > Date:   Mon Mar 12 11:36:33 2012 -0700
> > 
> >     x86/ioapic: Add register level checks to detect bogus io-apic entries
> > 
> > With out this commit, if the bios lists bogus io-apic's, then we will
> > see some error messages ("Unable to reset IRR for apic")during linux
> > boot which are benign. But as this patch breaks Xen, I am ok if these
> > don't get applied to 'stable'. Also I think it is Ingo who added the
> > 'stable' tag. Ingo, are you ok with this?
> 
> What stable trees did this already go into in the releases today?

None. That is why I am sending this advance warning so you don't
put it in.

> 
> You need to tell me what I need to revert here, SPECIFICALLY, and in
> what tree, if needed, otherwise I have no idea what is going on, sorry,
> I can't read minds.
> 
> > For the mainline, we have queued more patches to fix the Xen breakage.
> 
> And what is that supposed to mean to me?
> 
> Again, help me out here, this is making no sense at all.
> 
> How am I supposed to "not apply" a patch that I have never heard of?
> And how am I supposed to "not apply" a patch that I have already
> applied?
> 
> How about you all start over from the beginning and tell me EXACTLY what
> you want me to do here, because I sure as heck don't know what is going
> on...

Heh.

The patch titled "x86/ioapic: Add register level checks to detect bogus io-apic entries"
(git commit 73d63d038ee9f769f5e5b46792d227fe20e442c5) that is in v3.4-rc1, even
thought it has cc: stable@kernel.org, should _NOT_ be applied to the stable tree.

> 
> confused,
> 
> greg k-h

Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

[Konrad Rzeszutek Wilk]

> > Author: Suresh Siddha <suresh.b.siddha@intel.com>
> > Date:   Mon Mar 12 11:36:33 2012 -0700
> > 
> >     x86/ioapic: Add register level checks to detect bogus io-apic entries
> > 
> > With out this commit, if the bios lists bogus io-apic's, then we will
> > see some error messages ("Unable to reset IRR for apic")during linux
> > boot which are benign. But as this patch breaks Xen, I am ok if these
> > don't get applied to 'stable'. Also I think it is Ingo who added the
> > 'stable' tag. Ingo, are you ok with this?
> 
> What stable trees did this already go into in the releases today?

I see it in v3.2.x as:
273fb19 x86/ioapic: Add register level checks to detect bogus io-apic entries

And in 3.0.x:
c2ec63e x86/ioapic: Add register level checks to detect bogus io-apic entries

But I don't see it in 3.1.x tree?

> 
> You need to tell me what I need to revert here, SPECIFICALLY, and in
> what tree, if needed, otherwise I have no idea what is going on, sorry,
> I can't read minds.

Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

[Teck Choon Giam]

On Tue, Apr 3, 2012 at 9:28 PM, Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com> wrote:
>> > Author: Suresh Siddha <suresh.b.siddha@intel.com>
>> > Date: � Mon Mar 12 11:36:33 2012 -0700
>> >
>> > � � x86/ioapic: Add register level checks to detect bogus io-apic entries
>> >
>> > With out this commit, if the bios lists bogus io-apic's, then we will
>> > see some error messages ("Unable to reset IRR for apic")during linux
>> > boot which are benign. But as this patch breaks Xen, I am ok if these
>> > don't get applied to 'stable'. Also I think it is Ingo who added the
>> > 'stable' tag. Ingo, are you ok with this?
>>
>> What stable trees did this already go into in the releases today?
>
> I see it in v3.2.x as:
> 273fb19 x86/ioapic: Add register level checks to detect bogus io-apic entries
>
> And in 3.0.x:
> c2ec63e x86/ioapic: Add register level checks to detect bogus io-apic entries

And does this also affect 3.3.x?  I haven't test but guess it will?

# git log | grep -B 5 'x86/ioapic: Add register level checks to detect
bogus io-apic entries'

commit a998dc2fa76f496d2944f0602b920d1d10d7467d
Author: Suresh Siddha <suresh.b.siddha@intel.com>
Date:   Mon Mar 12 11:36:33 2012 -0700

    x86/ioapic: Add register level checks to detect bogus io-apic entries


Thanks.

Kindest regards,
Giam Teck Choon


>
> But I don't see it in 3.1.x tree?
>
>>
>> You need to tell me what I need to revert here, SPECIFICALLY, and in
>> what tree, if needed, otherwise I have no idea what is going on, sorry,
>> I can't read minds.
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at �http://vger.kernel.org/majordomo-info.html

Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

[Konrad Rzeszutek Wilk]

On Tue, Apr 03, 2012 at 10:26:42PM +0800, Teck Choon Giam wrote:
> On Tue, Apr 3, 2012 at 9:28 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> >> > Author: Suresh Siddha <suresh.b.siddha@intel.com>
> >> > Date: � Mon Mar 12 11:36:33 2012 -0700
> >> >
> >> > � � x86/ioapic: Add register level checks to detect bogus io-apic entries
> >> >
> >> > With out this commit, if the bios lists bogus io-apic's, then we will
> >> > see some error messages ("Unable to reset IRR for apic")during linux
> >> > boot which are benign. But as this patch breaks Xen, I am ok if these
> >> > don't get applied to 'stable'. Also I think it is Ingo who added the
> >> > 'stable' tag. Ingo, are you ok with this?
> >>
> >> What stable trees did this already go into in the releases today?
> >
> > I see it in v3.2.x as:
> > 273fb19 x86/ioapic: Add register level checks to detect bogus io-apic entries
> >
> > And in 3.0.x:
> > c2ec63e x86/ioapic: Add register level checks to detect bogus io-apic entries
> 
> And does this also affect 3.3.x?  I haven't test but guess it will?

Yup!
> 
> # git log | grep -B 5 'x86/ioapic: Add register level checks to detect
> bogus io-apic entries'
> 
> commit a998dc2fa76f496d2944f0602b920d1d10d7467d
> Author: Suresh Siddha <suresh.b.siddha@intel.com>
> Date:   Mon Mar 12 11:36:33 2012 -0700
> 
>     x86/ioapic: Add register level checks to detect bogus io-apic entries
> 

Greg, please also revert this one.

Re: Don't apply 9f022e54b8ea82d1ecdf3bd78d9ab9f44d6b0655 to stable please.

[Teck Choon Giam]

On Tue, Apr 3, 2012 at 10:31 PM, Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com> wrote:
> On Tue, Apr 03, 2012 at 10:26:42PM +0800, Teck Choon Giam wrote:
>> On Tue, Apr 3, 2012 at 9:28 PM, Konrad Rzeszutek Wilk
>> <konrad.wilk@oracle.com> wrote:
>> >> > Author: Suresh Siddha <suresh.b.siddha@intel.com>
>> >> > Date: � Mon Mar 12 11:36:33 2012 -0700
>> >> >
>> >> > � � x86/ioapic: Add register level checks to detect bogus io-apic entries
>> >> >
>> >> > With out this commit, if the bios lists bogus io-apic's, then we will
>> >> > see some error messages ("Unable to reset IRR for apic")during linux
>> >> > boot which are benign. But as this patch breaks Xen, I am ok if these
>> >> > don't get applied to 'stable'. Also I think it is Ingo who added the
>> >> > 'stable' tag. Ingo, are you ok with this?
>> >>
>> >> What stable trees did this already go into in the releases today?
>> >
>> > I see it in v3.2.x as:
>> > 273fb19 x86/ioapic: Add register level checks to detect bogus io-apic entries
>> >
>> > And in 3.0.x:
>> > c2ec63e x86/ioapic: Add register level checks to detect bogus io-apic entries
>>
>> And does this also affect 3.3.x? �I haven't test but guess it will?
>
> Yup!
>>
>> # git log | grep -B 5 'x86/ioapic: Add register level checks to detect
>> bogus io-apic entries'
>>
>> commit a998dc2fa76f496d2944f0602b920d1d10d7467d
>> Author: Suresh Siddha <suresh.b.siddha@intel.com>
>> Date: � Mon Mar 12 11:36:33 2012 -0700
>>
>> � � x86/ioapic: Add register level checks to detect bogus io-apic entries
>>
>
> Greg, please also revert this one.

I will include the various tree commit id as below:

linux-3.0.y:
commit c2ec63edaf48c90c3495eeb0b75bb05102fbf71a
Author: Suresh Siddha <suresh.b.siddha@intel.com>
Date:   Mon Mar 12 11:36:33 2012 -0700

    x86/ioapic: Add register level checks to detect bogus io-apic entries

linux-3.1.y: Don't have such commit and I guess it is due to EOL before Mar 12

linux-3.2.y:
commit 273fb194e86b795b08a724c7646d0f694949070b
Author: Suresh Siddha <suresh.b.siddha@intel.com>
Date:   Mon Mar 12 11:36:33 2012 -0700

    x86/ioapic: Add register level checks to detect bogus io-apic entries

linux-3.3.y:
commit a998dc2fa76f496d2944f0602b920d1d10d7467d
Author: Suresh Siddha <suresh.b.siddha@intel.com>
Date:   Mon Mar 12 11:36:33 2012 -0700

    x86/ioapic: Add register level checks to detect bogus io-apic entries


Thanks.

Kindest regards,
Giam Teck Choon