From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 23 Apr 2012 22:44:39 +0200 From: Daniel Vetter To: Chris Wilson Cc: Xi Wang , Daniel Vetter , Keith Packard , security@kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/2] drm/i915: fix integer overflow in i915_gem_execbuffer2() Message-ID: <20120423204439.GM4935@phenom.ffwll.local> References: <1335168402-25174-1-git-send-email-xi.wang@gmail.com> <1335169134_26001@CP5-2952> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1335169134_26001@CP5-2952> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, Apr 23, 2012 at 09:18:25AM +0100, Chris Wilson wrote: > On Mon, 23 Apr 2012 04:06:41 -0400, Xi Wang wrote: > > On 32-bit systems, a large args->buffer_count from userspace via ioctl > > may overflow the allocation size, leading to out-of-bounds access. > > > > This vulnerability was introduced in commit 8408c282 ("drm/i915: > > First try a normal large kmalloc for the temporary exec buffers"). > > > > Signed-off-by: Xi Wang > > Cc: Chris Wilson > > Cc: stable@vger.kernel.org > Reviewed-by: Chris Wilson Both patches picked up for -fixes, thanks. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48