From: Shaohua Li <shli@kernel.org>
To: Tao Guo <glorioustao@gmail.com>
Cc: linux-kernel@vger.kernel.org, Tao Guo <Tao.Guo@emc.com>,
Neil Brown <neilb@suse.de>, Jens Axboe <axboe@kernel.dk>,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core
Date: Tue, 5 Jun 2012 09:21:16 +0800 [thread overview]
Message-ID: <20120605012116.GA357@kernel.org> (raw)
In-Reply-To: <1338820911-4733-1-git-send-email-glorioustao@gmail.com>
On Mon, Jun 04, 2012 at 10:41:50AM -0400, Tao Guo wrote:
> Other components may also require an unplug callback, so move this
> function from md/raid to block generic layer.
I saw no point this should be generic code, for example, why blk_plug_cb only
handles only one request_queue? If umem needs unplug, just do in it.
next prev parent reply other threads:[~2012-06-05 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 14:41 [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core Tao Guo
2012-06-04 14:41 ` [PATCH 2/2] umem: fix up unplugging Tao Guo
2012-06-04 14:49 ` Tao Guo
2012-06-05 1:21 ` Shaohua Li [this message]
2012-06-05 1:48 ` [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core Tao.Guo
2012-06-06 2:07 ` Shaohua Li
2012-06-07 17:06 ` Tao.Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605012116.GA357@kernel.org \
--to=shli@kernel.org \
--cc=Tao.Guo@emc.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=glorioustao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).