From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 5 Jun 2012 09:21:16 +0800 From: Shaohua Li To: Tao Guo Cc: linux-kernel@vger.kernel.org, Tao Guo , Neil Brown , Jens Axboe , stable@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core Message-ID: <20120605012116.GA357@kernel.org> References: <1338820911-4733-1-git-send-email-glorioustao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1338820911-4733-1-git-send-email-glorioustao@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, Jun 04, 2012 at 10:41:50AM -0400, Tao Guo wrote: > Other components may also require an unplug callback, so move this > function from md/raid to block generic layer. I saw no point this should be generic code, for example, why blk_plug_cb only handles only one request_queue? If umem needs unplug, just do in it.