From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
alan@lxorguk.ukuu.org.uk,
Andreas Herrmann <andreas.herrmann3@amd.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: [ 46/54] cpufreq / powernow-k8: Remove usage of smp_processor_id() in preemptible code
Date: Mon, 29 Oct 2012 14:40:47 -0700 [thread overview]
Message-ID: <20121029213807.900755997@linuxfoundation.org> (raw)
In-Reply-To: <20121029213802.697479610@linuxfoundation.org>
3.4-stable review patch. If anyone has any objections, please let me know.
------------------
From: Andreas Herrmann <andreas.herrmann3@amd.com>
commit e4df1cbcc1f329e53a1fff7450b2229e0addff20 upstream.
Commit 6889125b8b4e09c5e53e6ecab3433bed1ce198c9
(cpufreq/powernow-k8: workqueue user shouldn't migrate the kworker to another CPU)
causes powernow-k8 to trigger a preempt warning, e.g.:
BUG: using smp_processor_id() in preemptible [00000000] code: cpufreq/3776
caller is powernowk8_target+0x20/0x49
Pid: 3776, comm: cpufreq Not tainted 3.6.0 #9
Call Trace:
[<ffffffff8125b447>] debug_smp_processor_id+0xc7/0xe0
[<ffffffff814877e7>] powernowk8_target+0x20/0x49
[<ffffffff81482b02>] __cpufreq_driver_target+0x82/0x8a
[<ffffffff81484fc6>] cpufreq_governor_performance+0x4e/0x54
[<ffffffff81482c50>] __cpufreq_governor+0x8c/0xc9
[<ffffffff81482e6f>] __cpufreq_set_policy+0x1a9/0x21e
[<ffffffff814839af>] store_scaling_governor+0x16f/0x19b
[<ffffffff81484f16>] ? cpufreq_update_policy+0x124/0x124
[<ffffffff8162b4a5>] ? _raw_spin_unlock_irqrestore+0x2c/0x49
[<ffffffff81483640>] store+0x60/0x88
[<ffffffff811708c0>] sysfs_write_file+0xf4/0x130
[<ffffffff8111243b>] vfs_write+0xb5/0x151
[<ffffffff811126e0>] sys_write+0x4a/0x71
[<ffffffff816319a9>] system_call_fastpath+0x16/0x1b
Fix this by by always using work_on_cpu().
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/cpufreq/powernow-k8.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
--- a/drivers/cpufreq/powernow-k8.c
+++ b/drivers/cpufreq/powernow-k8.c
@@ -1223,14 +1223,7 @@ static int powernowk8_target(struct cpuf
struct powernowk8_target_arg pta = { .pol = pol, .targfreq = targfreq,
.relation = relation };
- /*
- * Must run on @pol->cpu. cpufreq core is responsible for ensuring
- * that we're bound to the current CPU and pol->cpu stays online.
- */
- if (smp_processor_id() == pol->cpu)
- return powernowk8_target_fn(&pta);
- else
- return work_on_cpu(pol->cpu, powernowk8_target_fn, &pta);
+ return work_on_cpu(pol->cpu, powernowk8_target_fn, &pta);
}
/* Driver entry point to verify the policy and range of frequencies */
next prev parent reply other threads:[~2012-10-29 21:40 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 21:40 [ 00/54] 3.4.17-stable review Greg Kroah-Hartman
2012-10-29 21:40 ` [ 01/54] drm/radeon: add some new SI PCI ids Greg Kroah-Hartman
2012-10-29 21:40 ` [ 02/54] drm/radeon: add error output if VM CS fails on cayman Greg Kroah-Hartman
2012-10-29 21:40 ` [ 03/54] ALSA: hda - add dock support for Thinkpad T430 Greg Kroah-Hartman
2012-10-29 21:40 ` [ 04/54] gen_init_cpio: avoid stack overflow when expanding Greg Kroah-Hartman
2012-10-29 21:40 ` [ 05/54] fs/compat_ioctl.c: VIDEO_SET_SPU_PALETTE missing error check Greg Kroah-Hartman
2012-10-29 21:40 ` [ 06/54] drivers/rtc/rtc-imxdi.c: add missing spin lock initialization Greg Kroah-Hartman
2012-10-29 21:40 ` [ 07/54] genalloc: stop crashing the system when destroying a pool Greg Kroah-Hartman
2012-10-29 21:40 ` [ 08/54] ARM: 7559/1: smp: switch away from the idmap before updating init_mm.mm_count Greg Kroah-Hartman
2012-10-29 21:40 ` [ 09/54] x86, mm: Trim memory in memblock to be page aligned Greg Kroah-Hartman
2012-10-29 21:40 ` [ 10/54] mm: fix XFS oops due to dirty pages without buffers on s390 Greg Kroah-Hartman
2012-10-29 21:40 ` [ 11/54] SUNRPC: Get rid of the xs_error_report socket callback Greg Kroah-Hartman
2012-10-29 21:40 ` [ 12/54] SUNRPC: Clear the connect flag when socket state is TCP_CLOSE_WAIT Greg Kroah-Hartman
2012-10-29 21:40 ` [ 13/54] Revert "SUNRPC: Ensure we close the socket on EPIPE errors too..." Greg Kroah-Hartman
2012-10-29 21:40 ` [ 14/54] SUNRPC: Prevent races in xs_abort_connection() Greg Kroah-Hartman
2012-10-29 21:40 ` [ 15/54] xhci: Fix potential NULL ptr deref in command cancellation Greg Kroah-Hartman
2012-10-29 21:40 ` [ 16/54] sysfs: sysfs_pathname/sysfs_add_one: Use strlcat() instead of strcat() Greg Kroah-Hartman
2012-10-29 21:40 ` [ 17/54] Staging: android: binder: Fix memory leak on thread/process exit Greg Kroah-Hartman
2012-10-29 21:40 ` [ 18/54] Staging: android: binder: Allow using highmem for binder buffers Greg Kroah-Hartman
2012-10-29 21:40 ` [ 19/54] Drivers: hv: Cleanup error handling in vmbus_open() Greg Kroah-Hartman
2012-10-29 21:40 ` [ 20/54] ehci: fix Lucid nohandoff pci quirk to be more generic with BIOS versions Greg Kroah-Hartman
2012-10-29 21:40 ` [ 21/54] ehci: Add yet-another Lucid nohandoff pci quirk Greg Kroah-Hartman
2012-10-29 21:40 ` [ 22/54] usb-storage: add unusual_devs entry for Casio EX-N1 digital camera Greg Kroah-Hartman
2012-10-29 21:40 ` [ 23/54] usb hub: send clear_tt_buffer_complete events when canceling TT clear work Greg Kroah-Hartman
2012-10-29 21:40 ` [ 24/54] USB: whiteheat: fix memory leak in error path Greg Kroah-Hartman
2012-10-29 21:40 ` [ 25/54] USB: opticon: fix DMA from stack Greg Kroah-Hartman
2012-10-29 21:40 ` [ 26/54] USB: opticon: fix memory leak in error path Greg Kroah-Hartman
2012-10-29 21:40 ` [ 27/54] USB: serial: Fix memory leak in sierra_release() Greg Kroah-Hartman
2012-10-29 21:40 ` [ 28/54] USB: sierra: fix memory leak in attach error path Greg Kroah-Hartman
2012-10-29 21:40 ` [ 29/54] USB: sierra: fix memory leak in probe " Greg Kroah-Hartman
2012-10-29 21:40 ` [ 30/54] USB: mos7840: fix urb leak at release Greg Kroah-Hartman
2012-10-29 21:40 ` [ 31/54] USB: mos7840: fix port-device leak in error path Greg Kroah-Hartman
2012-10-29 21:40 ` [ 32/54] USB: mos7840: remove NULL-urb submission Greg Kroah-Hartman
2012-10-29 21:40 ` [ 33/54] USB: mos7840: remove invalid disconnect handling Greg Kroah-Hartman
2012-10-29 21:40 ` [ 34/54] vhost: fix mergeable bufs on BE hosts Greg Kroah-Hartman
2012-10-29 21:40 ` [ 35/54] ARM: SAMSUNG: Add naming of s3c64xx-spi devices Greg Kroah-Hartman
2012-11-04 6:17 ` Colin Cross
2012-11-05 7:51 ` Greg Kroah-Hartman
2012-11-05 7:55 ` Colin Cross
2012-10-29 21:40 ` [ 36/54] ARM: at91/tc: fix typo in the DT document Greg Kroah-Hartman
2012-10-29 21:40 ` [ 37/54] ARM: at91/i2c: change id to let i2c-gpio work Greg Kroah-Hartman
2012-10-29 21:40 ` [ 38/54] ARM: at91: at91sam9g10: fix SOC type detection Greg Kroah-Hartman
2012-10-29 21:40 ` [ 39/54] mac80211: check if key has TKIP type before updating IV Greg Kroah-Hartman
2012-10-29 21:40 ` [ 40/54] Bluetooth: SMP: Fix setting unknown auth_req bits Greg Kroah-Hartman
2012-10-29 21:40 ` [ 41/54] freezer: exec should clear PF_NOFREEZE along with PF_KTHREAD Greg Kroah-Hartman
2012-10-29 21:40 ` [ 42/54] dmaengine: sirf: fix a typo in dma_prep_interleaved Greg Kroah-Hartman
2012-10-29 21:40 ` [ 43/54] dmaengine: sirf: fix a typo in moving running dma_desc to active queue Greg Kroah-Hartman
2012-10-29 21:40 ` [ 44/54] dmaengine: imx-dma: fix missing unlock on error in imxdma_xfer_desc() Greg Kroah-Hartman
2012-10-29 21:40 ` [ 45/54] bcma: fix unregistration of cores Greg Kroah-Hartman
2012-10-29 21:40 ` Greg Kroah-Hartman [this message]
2012-10-29 21:40 ` [ 47/54] Revert "ath9k_hw: Updated AR9003 tx gain table for 5GHz" Greg Kroah-Hartman
2012-10-29 21:40 ` [ 48/54] x86, mm: Find_early_table_space based on ranges that are actually being mapped Greg Kroah-Hartman
2012-10-29 21:40 ` [ 49/54] x86, mm: Undo incorrect revert in arch/x86/mm/init.c Greg Kroah-Hartman
2012-10-29 21:40 ` [ 50/54] efi: Defer freeing boot services memory until after ACPI init Greg Kroah-Hartman
2012-10-29 21:40 ` [ 51/54] x86: efi: Turn off efi_enabled after setup on mixed fw/kernel Greg Kroah-Hartman
2012-10-29 21:40 ` [ 52/54] staging: comedi: amplc_pc236: fix invalid register access during detach Greg Kroah-Hartman
2012-10-29 21:40 ` [ 53/54] x86, mm: Use memblock memory loop instead of e820_RAM Greg Kroah-Hartman
2012-10-29 21:40 ` [ 54/54] drm/i915: no lvds quirk for Zotac ZDBOX SD ID12/ID13 Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029213807.900755997@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andreas.herrmann3@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).