From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Mon, 5 Nov 2012 08:41:49 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	bernhard.kohl@nsn.com, herton.krzesinski@canonical.com
Subject: Re: [ 00/24] 3.6.6-stable review
Message-ID: <20121105074149.GA1947@kroah.com>
References: <20121102170247.406319110@linuxfoundation.org>
 <CAEH94LhVHXEEk0XzL3z_EyUDpRMeP02MTUGBxzV5=oOxWGDu3g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEH94LhVHXEEk0XzL3z_EyUDpRMeP02MTUGBxzV5=oOxWGDu3g@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Mon, Nov 05, 2012 at 03:37:31PM +0800, Zhi Yong Wu wrote:
> HI, greg
> 
> Some of the patchset haven't passed the check of checkpatch.pl as below:
> 
> WARNING: line over 80 characters
> #85: FILE: drivers/block/floppy.c:4319:
> +			device_remove_file(&floppy_device[drive].dev, &dev_attr_cmos);
> 
> WARNING: line over 80 characters
> #419: FILE: drivers/scsi/qla2xxx/qla_target.c:744:
> +			ha->tgt.tgt_ops->update_sess(sess, fcport->d_id, fcport->loop_id,
> 
> WARNING: line over 80 characters
> #420: FILE: drivers/scsi/qla2xxx/qla_target.c:745:
> +						(fcport->flags & FCF_CONF_COMP_SUPPORTED));
> 
> WARNING: line over 80 characters
> #443: FILE: drivers/scsi/qla2xxx/qla_target.c:871:
> +		ha->tgt.tgt_ops->update_sess(sess, fcport->d_id, fcport->loop_id,
> 
> WARNING: line over 80 characters
> #444: FILE: drivers/scsi/qla2xxx/qla_target.c:872:
> +					(fcport->flags & FCF_CONF_COMP_SUPPORTED));
> 
> WARNING: line over 80 characters
> #488: FILE: drivers/scsi/qla2xxx/tcm_qla2xxx.c:1491:
> +			sess->s_id.b.domain, sess->s_id.b.area, sess->s_id.b.al_pa,
> 
> WARNING: line over 80 characters
> #514: FILE: drivers/scsi/qla2xxx/tcm_qla2xxx.c:1517:
> +			WARN(btree_remove32(&lport->lport_fcport_map, key) != se_nacl,
> 
> WARNING: line over 80 characters
> #516: FILE: drivers/scsi/qla2xxx/tcm_qla2xxx.c:1519:
> +			     sess->s_id.b.domain, sess->s_id.b.area, sess->s_id.b.al_pa);
> 
> WARNING: line over 80 characters
> #519: FILE: drivers/scsi/qla2xxx/tcm_qla2xxx.c:1522:
> +			     sess->s_id.b.domain, sess->s_id.b.area, sess->s_id.b.al_pa);
> 
> WARNING: line over 80 characters
> #530: FILE: drivers/scsi/qla2xxx/tcm_qla2xxx.c:1533:
> +			btree_insert32(&lport->lport_fcport_map, key, se_nacl, GFP_ATOMIC);
> 
> total: 0 errors, 10 warnings, 1094 lines checked

That's fine, take those up with the people who send them in for the
upstream kernel, I take them no-changes for the stable releases.

And really, the 80 characters is just a "hint", it's not a hard and fast
rule for anything here.  Especially for the old, and horrible, floppy
and scsi drivers :)

thanks,

greg k-h