* Re: kmemleak report on isp1763 and sierra MC8705 [not found] ` <50A3D0E1.4060209@ruggedcom.com> @ 2012-11-14 17:52 ` Johan Hovold 2012-11-21 1:15 ` Greg Kroah-Hartman 0 siblings, 1 reply; 3+ messages in thread From: Johan Hovold @ 2012-11-14 17:52 UTC (permalink / raw) To: Richard Retanubun Cc: Johan Hovold, Greg Kroah-Hartman, linux-kernel@vger.kernel.org, Alan Stern, Lennart Sorensen, Tang Nguyen, linux-usb mailing list, stable, Ben Hutchings On Wed, Nov 14, 2012 at 12:12:01PM -0500, Richard Retanubun wrote: > On 10/11/12 09:30 AM, Johan Hovold wrote: > Hi Johan, > > > There was a reference-count fix for the probe error path that went in to > > v3.5. Haven't read all the details on how you trigger your leak, but at > > the face of it, it could be related. > > > > Have a look at 0658a3366db7e27fa ("usb: use usb_serial_put in > > usb_serial_probe errors). If related, you should be seeing "Ignoring > > blacklisted interface #n" messages when you enable debug (e.g. #define > > DEBUG) in the sierra driver. > > That was it! Thanks so much for the research. > I can apply it cleanly to 3.0.22 and see usb_release_dev() being > called and thus no more kmemleak. > > > > > Greg, it seems to me that the fix referred to above should be backported > > to the earlier stable trees either way. > I would vote "yes" for this also. > > While my setup circumstances may be a corner case, (modem kept > resetting to re-establish PPP connection) it was leaking 1192 bytes > per occurrence. The leak affects every failed probe, for example due to blacklisted interfaces which is quite common, so commit 0658a3366db7 ("usb: use usb_serial_put in usb_serial_probe errors) should be backported to the <= 3.4 stable trees. Thanks for reporting, Johan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kmemleak report on isp1763 and sierra MC8705 2012-11-14 17:52 ` kmemleak report on isp1763 and sierra MC8705 Johan Hovold @ 2012-11-21 1:15 ` Greg Kroah-Hartman 2012-11-25 14:24 ` Ben Hutchings 0 siblings, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2012-11-21 1:15 UTC (permalink / raw) To: Johan Hovold Cc: Richard Retanubun, linux-kernel@vger.kernel.org, Alan Stern, Lennart Sorensen, Tang Nguyen, linux-usb mailing list, stable, Ben Hutchings On Wed, Nov 14, 2012 at 06:52:18PM +0100, Johan Hovold wrote: > On Wed, Nov 14, 2012 at 12:12:01PM -0500, Richard Retanubun wrote: > > On 10/11/12 09:30 AM, Johan Hovold wrote: > > Hi Johan, > > > > > There was a reference-count fix for the probe error path that went in to > > > v3.5. Haven't read all the details on how you trigger your leak, but at > > > the face of it, it could be related. > > > > > > Have a look at 0658a3366db7e27fa ("usb: use usb_serial_put in > > > usb_serial_probe errors). If related, you should be seeing "Ignoring > > > blacklisted interface #n" messages when you enable debug (e.g. #define > > > DEBUG) in the sierra driver. > > > > That was it! Thanks so much for the research. > > I can apply it cleanly to 3.0.22 and see usb_release_dev() being > > called and thus no more kmemleak. > > > > > > > > Greg, it seems to me that the fix referred to above should be backported > > > to the earlier stable trees either way. > > I would vote "yes" for this also. > > > > While my setup circumstances may be a corner case, (modem kept > > resetting to re-establish PPP connection) it was leaking 1192 bytes > > per occurrence. > > The leak affects every failed probe, for example due to blacklisted > interfaces which is quite common, so commit 0658a3366db7 ("usb: use > usb_serial_put in usb_serial_probe errors) should be backported to the > <= 3.4 stable trees. Thanks, now applied. greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kmemleak report on isp1763 and sierra MC8705 2012-11-21 1:15 ` Greg Kroah-Hartman @ 2012-11-25 14:24 ` Ben Hutchings 0 siblings, 0 replies; 3+ messages in thread From: Ben Hutchings @ 2012-11-25 14:24 UTC (permalink / raw) To: Richard Retanubun, Johan Hovold Cc: linux-kernel@vger.kernel.org, Alan Stern, Lennart Sorensen, Tang Nguyen, linux-usb mailing list, stable, Greg Kroah-Hartman [-- Attachment #1: Type: text/plain, Size: 1714 bytes --] On Tue, 2012-11-20 at 17:15 -0800, Greg Kroah-Hartman wrote: > On Wed, Nov 14, 2012 at 06:52:18PM +0100, Johan Hovold wrote: > > On Wed, Nov 14, 2012 at 12:12:01PM -0500, Richard Retanubun wrote: > > > On 10/11/12 09:30 AM, Johan Hovold wrote: > > > Hi Johan, > > > > > > > There was a reference-count fix for the probe error path that went in to > > > > v3.5. Haven't read all the details on how you trigger your leak, but at > > > > the face of it, it could be related. > > > > > > > > Have a look at 0658a3366db7e27fa ("usb: use usb_serial_put in > > > > usb_serial_probe errors). If related, you should be seeing "Ignoring > > > > blacklisted interface #n" messages when you enable debug (e.g. #define > > > > DEBUG) in the sierra driver. > > > > > > That was it! Thanks so much for the research. > > > I can apply it cleanly to 3.0.22 and see usb_release_dev() being > > > called and thus no more kmemleak. > > > > > > > > > > > Greg, it seems to me that the fix referred to above should be backported > > > > to the earlier stable trees either way. > > > I would vote "yes" for this also. > > > > > > While my setup circumstances may be a corner case, (modem kept > > > resetting to re-establish PPP connection) it was leaking 1192 bytes > > > per occurrence. > > > > The leak affects every failed probe, for example due to blacklisted > > interfaces which is quite common, so commit 0658a3366db7 ("usb: use > > usb_serial_put in usb_serial_probe errors) should be backported to the > > <= 3.4 stable trees. > > Thanks, now applied. Also queued up for 3.2. Ben. -- Ben Hutchings Never attribute to conspiracy what can adequately be explained by stupidity. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 828 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-25 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.44L0.1210291806360.31151-100000@netrider.rowland.org>
[not found] ` <509D804A.7080807@ruggedcom.com>
[not found] ` <CAMgPeKUPeJSKas2VOqbG+Nt5MOtdA3jUUCsFwUcDVhwDJJCr6A@mail.gmail.com>
[not found] ` <50A3D0E1.4060209@ruggedcom.com>
2012-11-14 17:52 ` kmemleak report on isp1763 and sierra MC8705 Johan Hovold
2012-11-21 1:15 ` Greg Kroah-Hartman
2012-11-25 14:24 ` Ben Hutchings
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).