From: Greg KH <gregkh@linuxfoundation.org>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Jerome Marchand <jmarchan@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Sam Hansen <solid.se7en@gmail.com>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: zram: fix invalid memory references during disk write
Date: Tue, 18 Dec 2012 19:49:49 -0800 [thread overview]
Message-ID: <20121219034949.GA22281@kroah.com> (raw)
In-Reply-To: <CAPkvG_c0HayXO50SKCd==T-M4W1r8JUSi_VgGDiP+M+i=DpbZA@mail.gmail.com>
On Tue, Dec 18, 2012 at 01:12:05PM -0800, Nitin Gupta wrote:
> On Tue, Dec 11, 2012 at 10:27 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Nov 29, 2012 at 10:45:09PM -0800, Nitin Gupta wrote:
> >> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling
> >> of incompressible pages") which caused invalid memory references
> >> during disk write. Invalid references could occur in two cases:
> >> - Incoming data expands on compression: In this case, reference was
> >> made to kunmap()'ed bio page.
> >> - Partial (non PAGE_SIZE) write with incompressible data: In this
> >> case, reference was made to a kfree()'ed buffer.
> >>
> >> Fixes bug 50081:
> >> https://bugzilla.kernel.org/show_bug.cgi?id=50081
> >>
> >> Upstream commit ID: c8f2f0d: zram: Fix handling of incompressible pages
> >> Apply to versions: 3.6.5, 3.6.6, 3.6.7, 3.6.8
> >>
> >> Cc: <stable@vger.kernel.org> # staging-next: 37b51fd: zram: factor-out
> >> # zram_decompress_page() function
> >> Signed-off-by: Nitin Gupta <ngupta@vflare.org>
> >> Reported-by: Mihail Kasadjikov <hamer.mk@gmail.com>
> >> Reported-by: Tomas M <tomas@slax.org>
> >> Reviewed-by: Minchan Kim <minchan@kernel.org>
> >> ---
> >> drivers/staging/zram/zram_drv.c | 39 ++++++++++++++++++++++++---------------
> >> 1 file changed, 24 insertions(+), 15 deletions(-)
> >
> > This patch fails to apply to 3.6.10:
> >
> > patching file drivers/staging/zram/zram_drv.c
> > Hunk #1 succeeded at 282 (offset 17 lines).
> > Hunk #2 FAILED at 286.
> > Hunk #3 succeeded at 319 (offset 17 lines).
> > Hunk #4 succeeded at 340 (offset 17 lines).
> > Hunk #5 succeeded at 353 (offset 17 lines).
> > Hunk #6 succeeded at 368 (offset 17 lines).
> > Hunk #7 succeeded at 385 (offset 17 lines).
> > 1 out of 7 hunks FAILED -- saving rejects to file drivers/staging/zram/zram_drv.c.rej
> >
> > Please redo this patch and resend it if you wish for it to be applied to
> > the 3.6-stable tree.
> >
> >
>
> Please apply this patch to stable tree asap.
3.6 is now end-of-life, there will not be any more releases for that
kernel series anymore, sorry.
greg k-h
next prev parent reply other threads:[~2012-12-19 3:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1354257909-2380-1-git-send-email-ngupta@vflare.org>
2012-11-30 6:58 ` zram: fix invalid memory references during disk write Nitin Gupta
2012-12-08 0:50 ` Nitin Gupta
2012-12-08 19:47 ` Greg KH
[not found] ` <20121211182720.GC29421@kroah.com>
2012-12-18 21:12 ` Nitin Gupta
2012-12-19 3:49 ` Greg KH [this message]
2012-12-19 7:21 ` Nitin Gupta
2012-12-19 15:08 ` Greg KH
2012-12-19 15:53 ` Nitin Gupta
2012-12-19 16:17 ` Greg KH
2012-12-19 17:21 ` Nitin Gupta
2012-12-19 17:39 ` Mitch Harder
2012-12-20 22:48 ` Nitin Gupta
2013-01-14 19:19 ` Greg KH
2013-01-15 0:48 ` Nitin Gupta
2013-01-15 12:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219034949.GA22281@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=jmarchan@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan.kim@gmail.com \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
--cc=solid.se7en@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).