From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , alan@lxorguk.ukuu.org.uk, Lukas Czerner , Carlos Maiolino , Eric Sandeen , "Theodore Tso" , CAI Qian Subject: [ 08/21] ext4: init pagevec in ext4_da_block_invalidatepages Date: Fri, 18 Jan 2013 17:19:26 -0800 Message-Id: <20130119010712.801322739@linuxfoundation.org> In-Reply-To: <20130119010710.897187774@linuxfoundation.org> References: <20130119010710.897187774@linuxfoundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Sandeen commit 66bea92c69477a75a5d37b9bfed5773c92a3c4b4 upstream. ext4_da_block_invalidatepages is missing a pagevec_init(), which means that pvec->cold contains random garbage. This affects whether the page goes to the front or back of the LRU when ->cold makes it to free_hot_cold_page() Reviewed-by: Lukas Czerner Reviewed-by: Carlos Maiolino Signed-off-by: Eric Sandeen Signed-off-by: "Theodore Ts'o" Signed-off-by: CAI Qian Signed-off-by: Greg Kroah-Hartman --- fs/ext4/inode.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1424,6 +1424,8 @@ static void ext4_da_block_invalidatepage index = mpd->first_page; end = mpd->next_page - 1; + + pagevec_init(&pvec, 0); while (index <= end) { nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE); if (nr_pages == 0)