From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 6 Feb 2013 12:00:46 +0100 From: Jens Axboe To: Tejun Heo Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, bfields@fieldses.org, skinsbursky@parallels.com, ebiederm@xmission.com, jmorris@namei.org, stable@vger.kernel.org Subject: Re: [PATCH 06/62] block: fix synchronization and limit check in blk_alloc_devt() Message-ID: <20130206110046.GG15092@kernel.dk> References: <1359854463-2538-1-git-send-email-tj@kernel.org> <1359854463-2538-7-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1359854463-2538-7-git-send-email-tj@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Sat, Feb 02 2013, Tejun Heo wrote: > idr allocation in blk_alloc_devt() wasn't synchronized against lookup > and removal, and its limit check was off by one - 1 << MINORBITS is > the number of minors allowed, not the maximum allowed minor. > > Add locking and rename MAX_EXT_DEVT to NR_EXT_DEVT and fix limit > checking. > > Signed-off-by: Tejun Heo > Cc: Jens Axboe > Cc: stable@vger.kernel.org Acked-by: Jens Axboe -- Jens Axboe