From: Kees Cook <kees@outflux.net>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
eparis@redhat.com, Christian Kujau <lists@nerdbynature.de>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmsg: Honor dmesg_restrict sysctl on /dev/kmsg
Date: Wed, 27 Feb 2013 10:05:47 -0800 [thread overview]
Message-ID: <20130227180547.GR26411@outflux.net> (raw)
In-Reply-To: <20130222181856.GA2419@hansolo.jdub.homelinux.org>
Hi,
On Fri, Feb 22, 2013 at 01:18:57PM -0500, Josh Boyer wrote:
> Originally, the addition of dmesg_restrict covered both the syslog
> method of accessing dmesg, as well as /dev/kmsg itself. This was done
> indirectly by security_syslog calling cap_syslog before doing any LSM
> checks.
Actually, are the security_syslog() checks in /dev/kmsg correct? There is
only one used in devkmsg_open which uses SYSLOG_ACTION_READ_ALL. Shouldn't
it be using SYSLOG_ACTION_OPEN? And have SYSLOG_ACTION_READ_ALL added to
devkmsg_read? (And should we add one for write?)
-Kees
--
Kees Cook
Chrome OS Security
next prev parent reply other threads:[~2013-02-27 18:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 18:18 [PATCH] kmsg: Honor dmesg_restrict sysctl on /dev/kmsg Josh Boyer
2013-02-27 17:54 ` Kees Cook
2013-02-27 18:01 ` Josh Boyer
2013-02-27 18:14 ` Kees Cook
2013-02-27 20:46 ` Eric Paris
2013-02-27 22:19 ` Josh Boyer
2013-02-27 22:34 ` Kees Cook
2013-03-22 21:54 ` Andrew Morton
2013-03-22 22:14 ` Josh Boyer
2013-04-01 23:51 ` Kees Cook
2013-04-02 1:05 ` Josh Boyer
2013-04-08 21:34 ` Kees Cook
2013-04-09 0:50 ` Josh Boyer
2013-04-09 15:48 ` [PATCH v2] " Josh Boyer
2013-04-09 16:33 ` Kees Cook
2013-04-24 17:44 ` Kay Sievers
2013-04-24 17:58 ` Josh Boyer
2013-04-24 19:50 ` Josh Boyer
2013-04-24 20:35 ` Kees Cook
2013-04-24 21:21 ` Josh Boyer
2013-04-24 21:36 ` Kees Cook
2013-04-24 21:51 ` Josh Boyer
2013-04-24 23:52 ` Kay Sievers
2013-04-24 21:30 ` Linus Torvalds
2013-04-24 21:41 ` Kees Cook
2013-04-24 22:01 ` Josh Boyer
2013-04-24 17:43 ` Josh Boyer
2013-02-27 18:05 ` Kees Cook [this message]
2013-02-27 18:13 ` [PATCH] " Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130227180547.GR26411@outflux.net \
--to=kees@outflux.net \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).