From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <jhovold@gmail.com>
Cc: "Evgeniy Polyakov" <zbr@ioremap.net>,
"Nicolas Ferre" <nicolas.ferre@atmel.com>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
"Imre Kaloz" <kaloz@openwrt.org>,
"Krzysztof Halasa" <khc@pm.waw.pl>,
"Eric Miao" <eric.y.miao@gmail.com>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Daniel Mack" <zonque@gmail.com>,
"Ville Syrjälä" <syrjala@sci.fi>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] ARM: w1-gpio: fix erroneous gpio requests
Date: Tue, 12 Mar 2013 13:20:28 -0700 [thread overview]
Message-ID: <20130312202028.GA6060@kroah.com> (raw)
In-Reply-To: <1363116094-8630-1-git-send-email-jhovold@gmail.com>
On Tue, Mar 12, 2013 at 08:21:34PM +0100, Johan Hovold wrote:
> Fix regression introduced by commit d2323cf773 ("onewire: w1-gpio: add
> ext_pullup_enable pin in platform data") which added a gpio entry to the
> platform data, but did not add the required initialisers to the board
> files using it. Consequently, the driver would request gpio 0 at probe,
> which could break other uses of the corresponding pin.
>
> On AT91 requesting gpio 0 changes the pin muxing for PIOA0, which, for
> instance, breaks SPI0 on at91sam9g20.
>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <jhovold@gmail.com>
> ---
>
> Not sure whose tree this should go in through, so adding relevant maintainers
> and authors as CC.
As I took the offending patch, I might as well take this fix for it as
well.
Unless anyone else objects?
thanks,
greg k-h
next prev parent reply other threads:[~2013-03-12 20:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 19:21 [PATCH] ARM: w1-gpio: fix erroneous gpio requests Johan Hovold
2013-03-12 20:20 ` Greg Kroah-Hartman [this message]
2013-03-12 20:24 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-12 21:17 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312202028.GA6060@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=jhovold@gmail.com \
--cc=kaloz@openwrt.org \
--cc=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=stable@vger.kernel.org \
--cc=syrjala@sci.fi \
--cc=zbr@ioremap.net \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).