From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 16 Mar 2013 06:33:52 -0700 From: Guenter Roeck To: Ben Hutchings Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mark Brown Subject: Re: [ 11/21] hwmon: (sht15) Check return value of regulator_enable() Message-ID: <20130316133352.GA25567@roeck-us.net> References: <20130312223245.109098379@linuxfoundation.org> <20130312223246.431610777@linuxfoundation.org> <1363407324.3937.169.camel@deadeye.wl.decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363407324.3937.169.camel@deadeye.wl.decadent.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Sat, Mar 16, 2013 at 04:15:24AM +0000, Ben Hutchings wrote: > On Tue, 2013-03-12 at 15:44 -0700, Greg Kroah-Hartman wrote: > > 3.0-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Mark Brown > > > > commit 3e78080f81481aa8340374d5a37ae033c1cf4272 upstream. > > > > Not having power is a pretty serious error so check that we are able to > > enable the supply and error out if we can't. > > > > Signed-off-by: Mark Brown > > Signed-off-by: Guenter Roeck > > > --- > > drivers/hwmon/sht15.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > --- a/drivers/hwmon/sht15.c > > +++ b/drivers/hwmon/sht15.c > > @@ -926,7 +926,13 @@ static int __devinit sht15_probe(struct > > if (voltage) > > data->supply_uV = voltage; > > > > - regulator_enable(data->reg); > > + ret = regulator_enable(data->reg); > > + if (ret != 0) { > > + dev_err(&pdev->dev, > > + "failed to enable regulator: %d\n", ret); > > + return ret; > > + } > > + > > /* > > * Setup a notifier block to update this if another device > > * causes the voltage to change > > Since this has now been released, I think you need this follow-up fix in > 3.0.y and 3.4.y: > Excellent catch. I submitted your patch to -stable. Thanks, Guenter