Re: [PATCH 3.8-stable] thermal: return an error on failure to register thermal

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Apr 03, 2013 at 09:38:55AM +0900, Jonghwan Choi wrote:
> 3.8-stable review patch.  If anyone has any objections, please let me know.

Ok, I object, given that I told you to change the format of the message
you send out.  Please look at how others on the stable@ mailing list
send "should this patch be applied" messages, and copy how that is done.

> ------------------
> 
> From: "Richard Guy Briggs <rbriggs@redhat.com>"
> 
> commit da28d966f6aa942ae836d09729f76a1647932309 upstream.
> 
> The return code from the registration of the thermal class is used to
> unallocate resources, but this failure isn't passed back to the caller of
> thermal_init.  Return this failure back to the caller.
> 
> This bug was introduced in changeset 4cb18728 which overwrote the return
> code
> when the variable was re-used to catch the return code of the registration
> of
> the genetlink thermal socket family.

You linewrapped the patch message, careful, you might mess up the patch
itself as well :(

> Signed-off-by: Richard Guy Briggs <rbriggs@redhat.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

You aren't signing off on it as well?  Why not?

thanks,

greg k-h