From: Daniel Vetter <daniel@ffwll.ch>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Airlie <airlied@gmail.com>, Tomas Melin <tomas.melin@iki.fi>,
Chris Wilson <chris@chris-wilson.co.uk>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring
Date: Wed, 10 Apr 2013 14:07:24 +0200 [thread overview]
Message-ID: <20130410120724.GJ27612@phenom.ffwll.local> (raw)
In-Reply-To: <20130410115901.GA4502@netboy>
On Wed, Apr 10, 2013 at 01:59:02PM +0200, Richard Cochran wrote:
> On Tue, Apr 09, 2013 at 09:51:30PM +0200, Daniel Vetter wrote:
> > It will be only consistent once we've restored all the crtcs. Since a
> > bunch of other callers also want to just restore a single crtc, add a
> > boolean to disable checking only where it doesn't make sense.
> >
> > Note that intel_modeset_setup_hw_state already has a call to
> > intel_modeset_check_state at the end, so we don't reduce the amount of
> > checking.
> >
> > v2: Try harder not to create a big patch (Chris).
>
> To what does tree does this patch apply?
>
> Tried v3.8.6 and master d02a9a89.
It's written against drm-intel-next-queued at
http://cgit.freedesktop.org/~danvet/drm-intel
I've thought that it should apply pretty cleanly against older kernels,
too. Apparently it conflicts a bit in intel_modeset_setup_hw_state, you
can just do the s/intel_crtc_restore_mode/__intel_set_mode/ change
manually.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-04-10 12:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130409172820.GC27612@phenom.ffwll.local>
2013-04-09 19:51 ` [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring Daniel Vetter
2013-04-10 11:59 ` Richard Cochran
2013-04-10 12:07 ` Daniel Vetter [this message]
2013-04-10 17:27 ` Richard Cochran
2013-04-10 18:32 ` Tomas Melin
2013-04-11 5:16 ` Tomas Melin
2013-04-10 20:03 ` [Intel-gfx] " Daniel Vetter
2013-04-10 20:10 ` Daniel Vetter
2013-04-11 17:52 ` [Intel-gfx] " Richard Cochran
2013-04-11 18:14 ` Daniel Vetter
2013-04-11 18:37 ` Richard Cochran
2013-04-12 6:59 ` Richard Cochran
2013-04-11 18:22 ` Daniel Vetter
2013-04-11 19:17 ` Chris Wilson
2013-04-11 19:28 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410120724.GJ27612@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tomas.melin@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox