From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 11 Apr 2013 20:17:42 +0100 From: Chris Wilson To: Daniel Vetter Cc: Intel Graphics Development , DRI Development , LKML , Dave Airlie , Tomas Melin , Richard Cochran , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring Message-ID: <20130411191742.GA8251@cantiga.alporthouse.com> References: <1365537090-11518-1-git-send-email-daniel.vetter@ffwll.ch> <1365704571-17122-1-git-send-email-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1365704571-17122-1-git-send-email-daniel.vetter@ffwll.ch> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Thu, Apr 11, 2013 at 08:22:50PM +0200, Daniel Vetter wrote: > It will be only consistent once we've restored all the crtcs. Since a > bunch of other callers also want to just restore a single crtc, add a > boolean to disable checking only where it doesn't make sense. > > Note that intel_modeset_setup_hw_state already has a call to > intel_modeset_check_state at the end, so we don't reduce the amount of > checking. > > v2: Try harder not to create a big patch (Chris). > > v3: Even smaller (still Chris). Also fix a trailing space. > > References: https://lkml.org/lkml/2013/3/16/60 > Cc: Tomas Melin > Cc: Richard Cochran > Cc: Chris Wilson > Cc: stable@vger.kernel.org > Signed-off-by: Daniel Vetter I'm happy that you are not touching any paths other than mentioned in the changelog, and that I think being quiet on the modeset is a good use of the 'force' semantics, so Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre