From: Will Deacon <will.deacon@arm.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Jonghwan Choi <jhbird.choi@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 3.8-stable] ARM: 7690/1: mm: fix CONFIG_LPAE typos
Date: Thu, 25 Apr 2013 10:01:47 +0100 [thread overview]
Message-ID: <20130425090147.GD12848@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1366878044.1349.19.camel@x61.thuisdomein>
On Thu, Apr 25, 2013 at 09:20:44AM +0100, Paul Bolle wrote:
> On Thu, 2013-04-25 at 17:02 +0900, Jonghwan Choi wrote:
> > This patch looks like it should be in the 3.8-stable tree, should we apply
> > it?
>
> That would be only the setup.c chunk. That fixes a typo introduced in
> v3.4 (see commit e5ab85800820edd907d3f43f285e1232f84d5a41
> ("ARM: 7382/1: mm: truncate memory banks to fit in 4GB space for classic
> MMU")). So, if that chunk is deemed appropriate for stable, you could
> consider the v3.4.y longterm tree too.
Even then, I don't think it's worth backporting this patch. membank->start
and membank->size are phys_addr_t, so with LPAE enabled, this check won't
trigger anyway. The #ifndef is just there for readability really (since the
printk message explicitly refers to 32-bit physical addresses).
So I wouldn't bother with this.
Will
next prev parent reply other threads:[~2013-04-25 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 23:02 [RESEND PATCH 3.8-stable] ARM: EXYNOS: Fix crash on soft reset on EXYNOS5440 Jonghwan Choi
2013-04-25 0:16 ` [PATCH 3.8-stable] ARM: 7699/1: sched_clock: Add more notrace to prevent Jonghwan Choi
2013-04-25 0:26 ` Stephen Boyd
2013-04-25 8:02 ` [PATCH 3.8-stable] ARM: 7690/1: mm: fix CONFIG_LPAE typos Jonghwan Choi
2013-04-25 8:20 ` Paul Bolle
2013-04-25 9:01 ` Will Deacon [this message]
2013-04-30 7:52 ` [PATCH 3.8-stable] lib/int_sqrt.c: optimize square root algorithm Jonghwan Choi
2013-04-30 17:32 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425090147.GD12848@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=jhbird.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pebolle@tiscali.nl \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox