From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, eranian@google.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] Fix perf LBR filtering
Date: Thu, 25 Apr 2013 19:00:37 +0200 [thread overview]
Message-ID: <20130425170037.GD16732@two.firstfloor.org> (raw)
In-Reply-To: <20130425164837.GD5828@dyad.programming.kicks-ass.net>
> Traping the read deals with the first. The second shouldn't be a problem since
> we generally only allow kernel info for CAP_ADMIN; if we don't already for LBR
> that needs to be fixed separately.
Where is that check? I don't see it.
Also remember that precise == 2 can enable LBR implicitly.
> That only leaves the third.. can we descern MMIO maps from the kernel page tables?
In theory you could use some bits in the PTE for vmalloc, but it would need quite a
few changes.
Also there may be corner cases where MMIO is in the direct mapping or in
the kernel mapping.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2013-04-25 17:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 23:04 [PATCH 1/2] Fix perf LBR filtering Andi Kleen
2013-04-24 23:04 ` [PATCH 2/2] perf, x86: Don't allow unusual PEBS raw flags Andi Kleen
2013-04-29 22:16 ` Stephane Eranian
2013-04-29 22:34 ` Andi Kleen
2013-04-29 23:05 ` Stephane Eranian
2013-05-02 7:37 ` Peter Zijlstra
2013-05-06 17:44 ` Stephane Eranian
2013-05-06 18:52 ` Peter Zijlstra
2013-05-06 22:43 ` Stephane Eranian
2013-05-07 6:48 ` Ingo Molnar
2013-05-07 8:48 ` Peter Zijlstra
2013-05-07 11:04 ` Ingo Molnar
2013-05-07 8:43 ` Peter Zijlstra
2013-04-24 23:20 ` [PATCH 1/2] Fix perf LBR filtering Ben Hutchings
2013-04-24 23:24 ` Greg KH
2013-04-25 16:25 ` Peter Zijlstra
2013-04-25 16:41 ` Andi Kleen
2013-04-25 16:48 ` Peter Zijlstra
2013-04-25 17:00 ` Andi Kleen [this message]
2013-04-25 17:18 ` Peter Zijlstra
2013-04-25 17:42 ` Andi Kleen
2013-04-26 7:56 ` Peter Zijlstra
2013-04-26 19:46 ` Andi Kleen
2013-05-01 11:51 ` Ingo Molnar
2013-05-01 11:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425170037.GD16732@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox