From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 25 Apr 2013 19:00:37 +0200 From: Andi Kleen To: Peter Zijlstra Cc: Andi Kleen , mingo@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 1/2] Fix perf LBR filtering Message-ID: <20130425170037.GD16732@two.firstfloor.org> References: <1366844694-2770-1-git-send-email-andi@firstfloor.org> <20130425162535.GA5828@dyad.programming.kicks-ass.net> <20130425164100.GC16732@two.firstfloor.org> <20130425164837.GD5828@dyad.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130425164837.GD5828@dyad.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: > Traping the read deals with the first. The second shouldn't be a problem since > we generally only allow kernel info for CAP_ADMIN; if we don't already for LBR > that needs to be fixed separately. Where is that check? I don't see it. Also remember that precise == 2 can enable LBR implicitly. > That only leaves the third.. can we descern MMIO maps from the kernel page tables? In theory you could use some bits in the PTE for vmalloc, but it would need quite a few changes. Also there may be corner cases where MMIO is in the direct mapping or in the kernel mapping. -Andi -- ak@linux.intel.com -- Speaking for myself only.