* [PATCH] drm: don't check modeset locks in panic handler [not found] <CAPM=9tw-Ssu7ZYBZX7ipGt9w7zYG91tKbWZguM5DLPaqTakJPA@mail.gmail.com> @ 2013-05-02 7:43 ` Daniel Vetter 2013-05-02 10:13 ` Borislav Petkov 0 siblings, 1 reply; 3+ messages in thread From: Daniel Vetter @ 2013-05-02 7:43 UTC (permalink / raw) To: DRI Development; +Cc: LKML, Daniel Vetter, Dave Airlie, Borislav Petkov, stable Since we know that locking is broken in that case and it's more important to not flood the dmesg with random gunk. Cc: Dave Airlie <airlied@gmail.com> Cc: Borislav Petkov <bp@alien8.de> References: https://groups.google.com/forum/?fromgroups=#!topic/linux.kernel/QFzFxSUeV4I Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/drm_crtc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 792c3e3..3be0802 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -78,6 +78,10 @@ void drm_warn_on_modeset_not_all_locked(struct drm_device *dev) { struct drm_crtc *crtc; + /* Locking is currently fubar in the panic handler. */ + if (oops_in_progress) + return; + list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) WARN_ON(!mutex_is_locked(&crtc->mutex)); -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: don't check modeset locks in panic handler 2013-05-02 7:43 ` [PATCH] drm: don't check modeset locks in panic handler Daniel Vetter @ 2013-05-02 10:13 ` Borislav Petkov 2013-05-02 20:45 ` Daniel Vetter 0 siblings, 1 reply; 3+ messages in thread From: Borislav Petkov @ 2013-05-02 10:13 UTC (permalink / raw) To: Daniel Vetter; +Cc: DRI Development, LKML, Dave Airlie, stable On Thu, May 02, 2013 at 09:43:05AM +0200, Daniel Vetter wrote: > Since we know that locking is broken in that case and it's more > important to not flood the dmesg with random gunk. > > Cc: Dave Airlie <airlied@gmail.com> > Cc: Borislav Petkov <bp@alien8.de> > References: https://groups.google.com/forum/?fromgroups=#!topic/linux.kernel/QFzFxSUeV4I Yeah, we have this nice redirector service on k.org which uses the Message-ID only and doesn't rely on some external URLs remaining stable. You could use that instead: Link: http://lkml.kernel.org/r/20130502000206.GH15623@pd.tnic > Cc: stable@vger.kernel.org > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/drm_crtc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 792c3e3..3be0802 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -78,6 +78,10 @@ void drm_warn_on_modeset_not_all_locked(struct drm_device *dev) > { > struct drm_crtc *crtc; > > + /* Locking is currently fubar in the panic handler. */ > + if (oops_in_progress) > + return; > + > list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) > WARN_ON(!mutex_is_locked(&crtc->mutex)); Yep, thanks. Reported-and-tested-by: Borislav Petkov <bp@suse.de> -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: don't check modeset locks in panic handler 2013-05-02 10:13 ` Borislav Petkov @ 2013-05-02 20:45 ` Daniel Vetter 0 siblings, 0 replies; 3+ messages in thread From: Daniel Vetter @ 2013-05-02 20:45 UTC (permalink / raw) To: Borislav Petkov; +Cc: Daniel Vetter, DRI Development, LKML, Dave Airlie, stable On Thu, May 02, 2013 at 12:13:08PM +0200, Borislav Petkov wrote: > On Thu, May 02, 2013 at 09:43:05AM +0200, Daniel Vetter wrote: > > Since we know that locking is broken in that case and it's more > > important to not flood the dmesg with random gunk. > > > > Cc: Dave Airlie <airlied@gmail.com> > > Cc: Borislav Petkov <bp@alien8.de> > > References: https://groups.google.com/forum/?fromgroups=#!topic/linux.kernel/QFzFxSUeV4I > > Yeah, we have this nice redirector service on k.org which uses the > Message-ID only and doesn't rely on some external URLs remaining stable. > You could use that instead: > > Link: http://lkml.kernel.org/r/20130502000206.GH15623@pd.tnic > > > Cc: stable@vger.kernel.org > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > --- > > drivers/gpu/drm/drm_crtc.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > index 792c3e3..3be0802 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -78,6 +78,10 @@ void drm_warn_on_modeset_not_all_locked(struct drm_device *dev) > > { > > struct drm_crtc *crtc; > > > > + /* Locking is currently fubar in the panic handler. */ > > + if (oops_in_progress) > > + return; > > + > > list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) > > WARN_ON(!mutex_is_locked(&crtc->mutex)); > > Yep, thanks. > > Reported-and-tested-by: Borislav Petkov <bp@suse.de> Thanks for testing, patch applied to drm-intel-fixes. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-02 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAPM=9tw-Ssu7ZYBZX7ipGt9w7zYG91tKbWZguM5DLPaqTakJPA@mail.gmail.com>
2013-05-02 7:43 ` [PATCH] drm: don't check modeset locks in panic handler Daniel Vetter
2013-05-02 10:13 ` Borislav Petkov
2013-05-02 20:45 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox