From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20130507035845.887141450@goodmis.org> Date: Mon, 06 May 2013 23:57:42 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Jens Axboe Subject: [030/126] block: avoid using uninitialized value in from queue_var_store References: <20130507035712.909872333@goodmis.org> Content-Disposition: inline; filename=0030-block-avoid-using-uninitialized-value-in-from-queue_.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.6.11.3 stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann [ Upstream commit c678ef5286ddb5cf70384ad5af286b0afc9b73e1 ] As found by gcc-4.8, the QUEUE_SYSFS_BIT_FNS macro creates functions that use a value generated by queue_var_store independent of whether that value was set or not. block/blk-sysfs.c: In function 'queue_store_nonrot': block/blk-sysfs.c:244:385: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized] Unlike most other such warnings, this one is not a false positive, writing any non-number string into the sysfs files indeed has an undefined result, rather than returning an error. Signed-off-by: Arnd Bergmann Signed-off-by: Jens Axboe Signed-off-by: Steven Rostedt --- block/blk-sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index 9628b29..59e77ef 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -207,6 +207,8 @@ queue_store_##name(struct request_queue *q, const char *page, size_t count) \ unsigned long val; \ ssize_t ret; \ ret = queue_var_store(&val, page, count); \ + if (ret < 0) \ + return ret; \ if (neg) \ val = !val; \ \ -- 1.7.10.4