From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20130507035848.296583047@goodmis.org> Date: Mon, 06 May 2013 23:57:56 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Frederic Weisbecker , Namhyung Kim , Namhyung Kim Subject: [044/126] tracing: Fix double free when function profile init failed References: <20130507035712.909872333@goodmis.org> Content-Disposition: inline; filename=0044-tracing-Fix-double-free-when-function-profile-init-f.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.6.11.3 stable review patch. If anyone has any objections, please let me know. ------------------ From: Namhyung Kim [ Upstream commit 83e03b3fe4daffdebbb42151d5410d730ae50bd1 ] On the failure path, stat->start and stat->pages will refer same page. So it'll attempt to free the same page again and get kernel panic. Link: http://lkml.kernel.org/r/1364820385-32027-1-git-send-email-namhyung@kernel.org Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: stable@vger.kernel.org Signed-off-by: Namhyung Kim Signed-off-by: Steven Rostedt --- kernel/trace/ftrace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index bef5ebc..a1dd715 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -642,7 +642,6 @@ int ftrace_profile_pages_init(struct ftrace_profile_stat *stat) free_page(tmp); } - free_page((unsigned long)stat->pages); stat->pages = NULL; stat->start = NULL; -- 1.7.10.4