From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20130507035851.742899058@goodmis.org> Date: Mon, 06 May 2013 23:58:17 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Emese Revfy , PaX Team , Kees Cook , Al Viro , Oleg Nesterov , "Eric W. Biederman" , Serge Hallyn , Andrew Morton Subject: [065/126] kernel/signal.c: stop info leak via the tkill and the tgkill syscalls References: <20130507035712.909872333@goodmis.org> Content-Disposition: inline; filename=0065-kernel-signal.c-stop-info-leak-via-the-tkill-and-the.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.6.11.3 stable review patch. If anyone has any objections, please let me know. ------------------ From: Emese Revfy [ Upstream commit b9e146d8eb3b9ecae5086d373b50fa0c1f3e7f0f ] This fixes a kernel memory contents leak via the tkill and tgkill syscalls for compat processes. This is visible in the siginfo_t->_sifields._rt.si_sigval.sival_ptr field when handling signals delivered from tkill. The place of the infoleak: int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from) { ... put_user_ex(ptr_to_compat(from->si_ptr), &to->si_ptr); ... } Signed-off-by: Emese Revfy Reviewed-by: PaX Team Signed-off-by: Kees Cook Cc: Al Viro Cc: Oleg Nesterov Cc: "Eric W. Biederman" Cc: Serge Hallyn Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Steven Rostedt --- kernel/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/signal.c b/kernel/signal.c index be4f856..6b9b817 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -2898,7 +2898,7 @@ do_send_specific(pid_t tgid, pid_t pid, int sig, struct siginfo *info) static int do_tkill(pid_t tgid, pid_t pid, int sig) { - struct siginfo info; + struct siginfo info = {}; info.si_signo = sig; info.si_errno = 0; -- 1.7.10.4