From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] perf, x86: Don't allow unusual PEBS raw flags
Date: Tue, 7 May 2013 10:43:14 +0200 [thread overview]
Message-ID: <20130507084314.GC9688@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <CABPqkBREmUfuPBvCvBF+4YNvzfuqgDffVvfUFE5_w6Yx88mBZQ@mail.gmail.com>
On Tue, May 07, 2013 at 12:43:04AM +0200, Stephane Eranian wrote:
> But that implies that you'd know that on Intel precise mode uses PEBS
> and that PEBS
> does not take cmask events. That seems to contradict the philosophy of
> perf_events
> where the kernel does the work for you.
This is basically raw event territory (hidden in a nice syntax). This is very
much a you're on your own case.
But it appears there's more behind this than was said; which makes this patch
submission duplicitous and trying to sneak one past the maintainers -- that's
very much not how things are done.
I'm not taking anything like this until the Changelog reflects the true
purpose.
next prev parent reply other threads:[~2013-05-07 8:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 23:04 [PATCH 1/2] Fix perf LBR filtering Andi Kleen
2013-04-24 23:04 ` [PATCH 2/2] perf, x86: Don't allow unusual PEBS raw flags Andi Kleen
2013-04-29 22:16 ` Stephane Eranian
2013-04-29 22:34 ` Andi Kleen
2013-04-29 23:05 ` Stephane Eranian
2013-05-02 7:37 ` Peter Zijlstra
2013-05-06 17:44 ` Stephane Eranian
2013-05-06 18:52 ` Peter Zijlstra
2013-05-06 22:43 ` Stephane Eranian
2013-05-07 6:48 ` Ingo Molnar
2013-05-07 8:48 ` Peter Zijlstra
2013-05-07 11:04 ` Ingo Molnar
2013-05-07 8:43 ` Peter Zijlstra [this message]
2013-04-24 23:20 ` [PATCH 1/2] Fix perf LBR filtering Ben Hutchings
2013-04-24 23:24 ` Greg KH
2013-04-25 16:25 ` Peter Zijlstra
2013-04-25 16:41 ` Andi Kleen
2013-04-25 16:48 ` Peter Zijlstra
2013-04-25 17:00 ` Andi Kleen
2013-04-25 17:18 ` Peter Zijlstra
2013-04-25 17:42 ` Andi Kleen
2013-04-26 7:56 ` Peter Zijlstra
2013-04-26 19:46 ` Andi Kleen
2013-05-01 11:51 ` Ingo Molnar
2013-05-01 11:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507084314.GC9688@dyad.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox