From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 28 May 2013 17:48:01 +0100 From: Matthew Garrett To: Bjorn Helgaas Cc: Matt Fleming , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , Matt Fleming , Seth Forshee , Jesse Barnes , stable@vger.kernel.org Subject: Re: [PATCH] x86/PCI: setup data may be in highmem Message-ID: <20130528164801.GA2345@srcf.ucam.org> References: <1369215782-32697-1-git-send-email-matt@console-pimps.org> <20130528113617.GR14575@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote: > On Tue, May 28, 2013 at 5:36 AM, Matt Fleming wrote: > > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: > >> pcibios_add_device() is mostly called at boot-time, when > >> early_ioremap() probably works well. But it's also called when we > >> hot-add devices later, and it looks like early_ioremap() will then > >> generate warnings because "system_state != SYSTEM_BOOTING". > > > > Oops. Good point. Is there any reason we can't use ioremap()? > > I assume Matthew had some reason for avoiding that in the first place, > so I hope he'll chime in. I have no recollection of why I did it that way. If this is all happening late enough for ioremap() to work then that sounds fine. -- Matthew Garrett | mjg59@srcf.ucam.org