From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20130603221153.475194479@goodmis.org> Date: Mon, 03 Jun 2013 18:10:24 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wei Yongjun , Alasdair G Kergon Subject: [08/65] dm snapshot: fix error return code in snapshot_ctr References: <20130603221016.243553628@goodmis.org> Content-Disposition: inline; filename=0008-dm-snapshot-fix-error-return-code-in-snapshot_ctr.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.6.11.5 stable review patch. If anyone has any objections, please let me know. ------------------ From: Wei Yongjun [ Upstream commit 09e8b813897a0f85bb401435d009228644c81214 ] Return -ENOMEM instead of success if unable to allocate pending exception mempool in snapshot_ctr. Signed-off-by: Wei Yongjun Cc: stable@vger.kernel.org Signed-off-by: Alasdair G Kergon Signed-off-by: Steven Rostedt --- drivers/md/dm-snap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index a143921..456ef7a 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c @@ -1117,6 +1117,7 @@ static int snapshot_ctr(struct dm_target *ti, unsigned int argc, char **argv) s->pending_pool = mempool_create_slab_pool(MIN_IOS, pending_cache); if (!s->pending_pool) { ti->error = "Could not allocate mempool for pending exceptions"; + r = -ENOMEM; goto bad_pending_pool; } -- 1.7.10.4