From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-Id: <20130603221157.381227249@goodmis.org> Date: Mon, 03 Jun 2013 18:10:45 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mike Galbraith , Eric Dumazet , "David S. Miller" Subject: [29/65] tcp: force a dst refcount when prequeue packet References: <20130603221016.243553628@goodmis.org> Content-Disposition: inline; filename=0029-tcp-force-a-dst-refcount-when-prequeue-packet.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: 3.6.11.5 stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 093162553c33e9479283e107b4431378271c735d ] Before escaping RCU protected section and adding packet into prequeue, make sure the dst is refcounted. Reported-by: Mike Galbraith Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Steven Rostedt --- include/net/tcp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net/tcp.h b/include/net/tcp.h index 1f000ff..9297897 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -1015,6 +1015,7 @@ static inline bool tcp_prequeue(struct sock *sk, struct sk_buff *skb) if (sysctl_tcp_low_latency || !tp->ucopy.task) return false; + skb_dst_force(skb); __skb_queue_tail(&tp->ucopy.prequeue, skb); tp->ucopy.memory += skb->truesize; if (tp->ucopy.memory > sk->sk_rcvbuf) { -- 1.7.10.4