From: Willy Tarreau <w@1wt.eu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lotfi Manseur <lotfi.manseur@gmail.com>,
stable@vger.kernel.org,
Wojciech M Zabolotny <W.Zabolotny@elka.pw.edu.pl>,
Nicolas Palix <nicolas.palix@imag.fr>,
Lotfi Manseur <lotfi.manseur@imag.fr>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops
Date: Fri, 7 Jun 2013 20:49:48 +0200 [thread overview]
Message-ID: <20130607184948.GO19006@1wt.eu> (raw)
In-Reply-To: <20130607173009.GC29371@kroah.com>
On Fri, Jun 07, 2013 at 10:30:09AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 07, 2013 at 03:14:32PM +0200, Lotfi Manseur wrote:
> > Handle null termios in ftdi_set_termios(), introduced in
> > commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846
> > This has been corrected in the mainline by
> > commits c515598e0f5769916c31c00392cc2bfe6af74e55 and
> > a816e3113b63753c330ca4751ea1d208e93e3015.
>
> Then why shouldn't we just include those commit instead of your patch,
> which looks much different from these?
>
> I'd much rather take the originals, not something else.
Indeed. I've checked, and the second commit was just cosmetic (silence
a warning reported by sparse for ptr == 0 introduced in the first one).
The context is minimally different (original commit introduces a jump
to a label whose context has changed). I tend to think that the merged
fix has less changes of being incorrectly applied, but given their
triviality we could very well merge the original ones instead, and
keep initial authorship BTW.
Willy
next prev parent reply other threads:[~2013-06-07 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 13:14 [PATCH] USB: serial/ftdi_sio.c Fix kernel oops Lotfi Manseur
2013-06-07 13:47 ` Willy Tarreau
2013-06-07 13:56 ` Sergei Shtylyov
2013-06-07 17:30 ` Greg Kroah-Hartman
2013-06-07 18:49 ` Willy Tarreau [this message]
2013-06-10 21:03 ` Greg Kroah-Hartman
2013-06-13 3:35 ` Ben Hutchings
2013-06-17 15:30 ` Nicolas Palix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607184948.GO19006@1wt.eu \
--to=w@1wt.eu \
--cc=W.Zabolotny@elka.pw.edu.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lotfi.manseur@gmail.com \
--cc=lotfi.manseur@imag.fr \
--cc=nicolas.palix@imag.fr \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox