stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Rick Macklem <rmacklem@uoguelph.ca>,
	"J. Bruce Fields" <bfields@redhat.com>
Subject: [ 7/8] nfsd4: fix decoding of compounds across page boundaries
Date: Thu, 11 Jul 2013 15:20:36 -0700	[thread overview]
Message-ID: <20130711221932.103555136@linuxfoundation.org> (raw)
In-Reply-To: <20130711221931.216612791@linuxfoundation.org>

3.0-stable review patch.  If anyone has any objections, please let me know.

------------------

From: "J. Bruce Fields" <bfields@redhat.com>

commit 247500820ebd02ad87525db5d9b199e5b66f6636 upstream.

A freebsd NFSv4.0 client was getting rare IO errors expanding a tarball.
A network trace showed the server returning BAD_XDR on the final getattr
of a getattr+write+getattr compound.  The final getattr started on a
page boundary.

I believe the Linux client ignores errors on the post-write getattr, and
that that's why we haven't seen this before.

Reported-by: Rick Macklem <rmacklem@uoguelph.ca>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/nfsd/nfs4xdr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -159,8 +159,8 @@ static __be32 *read_buf(struct nfsd4_com
 	 */
 	memcpy(p, argp->p, avail);
 	/* step to next page */
-	argp->p = page_address(argp->pagelist[0]);
 	argp->pagelist++;
+	argp->p = page_address(argp->pagelist[0]);
 	if (argp->pagelen < PAGE_SIZE) {
 		argp->end = argp->p + (argp->pagelen>>2);
 		argp->pagelen = 0;



  parent reply	other threads:[~2013-07-11 22:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
2013-07-11 22:20 ` [ 1/8] libceph: Fix NULL pointer dereference in auth client code Greg Kroah-Hartman
2013-07-11 22:20 ` [ 2/8] drivers/cdrom/cdrom.c: use kzalloc() for failing hardware Greg Kroah-Hartman
2013-07-11 22:20 ` [ 3/8] hpfs: better test for errors Greg Kroah-Hartman
2013-07-11 22:20 ` [ 4/8] block: do not pass disk names as format strings Greg Kroah-Hartman
2013-07-11 22:20 ` [ 5/8] crypto: sanitize argument for format string Greg Kroah-Hartman
2013-07-11 22:20 ` [ 6/8] MAINTAINERS: add stable_kernel_rules.txt to stable maintainer information Greg Kroah-Hartman
2013-07-12  3:36   ` Ben Hutchings
2013-07-12  3:48     ` Greg Kroah-Hartman
2013-07-11 22:20 ` Greg Kroah-Hartman [this message]
2013-07-11 22:20 ` [ 8/8] SCSI: sd: Fix parsing of temporary cache mode prefix Greg Kroah-Hartman
2013-07-12 13:54 ` [ 0/8] 3.0.86-stable review Guenter Roeck
2013-07-12 17:29   ` Greg Kroah-Hartman
2013-07-12 17:22 ` Shuah Khan
2013-07-13  4:17 ` Satoru Takeuchi
2013-07-13  4:48   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130711221932.103555136@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=bfields@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmacklem@uoguelph.ca \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).